Bug 68953 - [chromium] Guard accelerated skia drawing logic with its own define to remove dependency on USE(THREADED_COMPOSITING)
Summary: [chromium] Guard accelerated skia drawing logic with its own define to remove...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-27 16:32 PDT by James Robinson
Modified: 2011-09-27 16:50 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.65 KB, patch)
2011-09-27 16:33 PDT, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2011-09-27 16:32:05 PDT
[chromium] Guard accelerated skia drawing logic with its own define to remove dependency on USE(THREADED_COMPOSITING)
Comment 1 James Robinson 2011-09-27 16:33:57 PDT
Created attachment 108929 [details]
Patch
Comment 2 Kenneth Russell 2011-09-27 16:44:35 PDT
Comment on attachment 108929 [details]
Patch

Looks fine. Do you want to add another GYP variable to Source/WebKit/chromium/features.gypi?
Comment 3 James Robinson 2011-09-27 16:47:58 PDT
I think we can do that when it's necessary - AFAIK so far only one person (Alok) has really worked on this, so it's pretty easy for him to just set it locally.
Comment 4 James Robinson 2011-09-27 16:50:09 PDT
Comment on attachment 108929 [details]
Patch

Clearing flags on attachment: 108929

Committed r96172: <http://trac.webkit.org/changeset/96172>
Comment 5 James Robinson 2011-09-27 16:50:12 PDT
All reviewed patches have been landed.  Closing bug.