Bug 68945 - svg/custom/oversized-pattern-scale.svg is useless because the interesting part of the test is off the screen
Summary: svg/custom/oversized-pattern-scale.svg is useless because the interesting par...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-27 15:47 PDT by Tim Horton
Modified: 2011-09-27 18:12 PDT (History)
3 users (show)

See Also:


Attachments
patch to fix both tests added in r96155 (32.02 KB, patch)
2011-09-27 16:10 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
patch (30.34 KB, patch)
2011-09-27 16:18 PDT, Tim Horton
darin: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2011-09-27 15:47:25 PDT
The transition point checking if we're scaling correctly is way off the right edge of the DRT window.
Comment 1 Tim Horton 2011-09-27 15:48:33 PDT
Also it seems like somehow the new baselines ended up in the generic platform results accidentally, I'll fix that too.
Comment 2 Tim Horton 2011-09-27 16:02:15 PDT
Actually, instead I'm going to fix them so that they can stay in the generic platform results. I'm dropping the scrollbar in oversized-pattern-scale and not using the gradient anymore in transformed-pattern-clamp-svg-root, so they should be good everywhere.
Comment 3 Tim Horton 2011-09-27 16:10:33 PDT
Created attachment 108922 [details]
patch to fix both tests added in r96155
Comment 4 Tim Horton 2011-09-27 16:14:50 PDT
Err, forgot about the scrollbars.
Comment 5 Tim Horton 2011-09-27 16:18:57 PDT
Created attachment 108924 [details]
patch
Comment 6 WebKit Review Bot 2011-09-27 16:53:02 PDT
Comment on attachment 108924 [details]
patch

Attachment 108924 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9878481

New failing tests:
svg/custom/oversized-pattern-scale.svg
svg/custom/transformed-pattern-clamp-svg-root.svg
Comment 7 Tim Horton 2011-09-27 16:54:50 PDT
(In reply to comment #6)
> (From update of attachment 108924 [details])
> Attachment 108924 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/9878481
> 
> New failing tests:
> svg/custom/oversized-pattern-scale.svg
> svg/custom/transformed-pattern-clamp-svg-root.svg

Ahh, and now that someone's checked in Chromium results for the original versions of these tests, I should have been expecting this.
Comment 8 Tim Horton 2011-09-27 18:12:07 PDT
Landed in r96176, will require removal of the previously added platform-specific results.