Bug 68941 - Fix potential SVG performance regression (over-invalidation of caches) from 96052.
Summary: Fix potential SVG performance regression (over-invalidation of caches) from 9...
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Keywords: InRadar
Depends on:
Reported: 2011-09-27 15:08 PDT by Tim Horton
Modified: 2011-09-28 01:05 PDT (History)
3 users (show)

See Also:

patch (1.90 KB, patch)
2011-09-27 15:26 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2011-09-27 15:08:49 PDT
Because of https://bugs.webkit.org/show_bug.cgi?id=68457, I added code to drop objects from the SVGResources cache when the target changes. It turns out (validating Niko and Rob's concerns in the aforementioned bug) that there's no need to do this for any case (that I've come up with so far) except filters, as filters are the only resource which makes use of its targets style.

So, we should only do the cache drop if we have a filter.

Patch coming soon.
Comment 1 Radar WebKit Bug Importer 2011-09-27 15:09:06 PDT
Comment 2 Tim Horton 2011-09-27 15:09:21 PDT
Comment 3 Tim Horton 2011-09-27 15:26:23 PDT
Created attachment 108913 [details]
Comment 4 Zoltan Herczeg 2011-09-27 23:47:06 PDT
Comment on attachment 108913 [details]

Comment 5 WebKit Review Bot 2011-09-28 01:05:55 PDT
Comment on attachment 108913 [details]

Clearing flags on attachment: 108913

Committed r96203: <http://trac.webkit.org/changeset/96203>
Comment 6 WebKit Review Bot 2011-09-28 01:05:59 PDT
All reviewed patches have been landed.  Closing bug.