RESOLVED FIXED 68930
Web Inspector: Refactor searching in inspector, add test (fixed non regex search). 
https://bugs.webkit.org/show_bug.cgi?id=68930
Summary Web Inspector: Refactor searching in inspector, add test (fixed non regex sea...
Vsevolod Vlasov
Reported 2011-09-27 13:43:29 PDT
Refactor searching in inspector, add test (+fix).
Attachments
Patch (28.30 KB, patch)
2011-09-27 14:59 PDT, Vsevolod Vlasov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-09-27 14:59:47 PDT
Created attachment 108906 [details] Patch
Vsevolod Vlasov
Comment 2 2011-09-27 15:02:35 PDT
We will need search in debugger agent as well, so moved it out of page agent. Added test. Fixed non regex case (added " != notFound" to condition) which is never used yet, but will probably be used for search in multiple scripts.
Yury Semikhatsky
Comment 3 2011-09-28 00:49:09 PDT
Comment on attachment 108906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108906&action=review > LayoutTests/ChangeLog:3 > + Web Inspector: Refactor searching in inspector, add test (+fix). What is (+fix) in the title? Also the log entry should contain a description of the changes made. > Source/WebCore/inspector/ContentSearchUtils.h:44 > + ContentSearchUtils() { } You may use a namespace instead.
Vsevolod Vlasov
Comment 4 2011-09-28 04:56:02 PDT
Committed r96215: <http://trac.webkit.org/changeset/96215>
Note You need to log in before you can comment on or make changes to this bug.