Bug 68925 - Add layout test for WaveShaperNode
Summary: Add layout test for WaveShaperNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-27 12:36 PDT by Chris Rogers
Modified: 2011-09-27 19:58 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.68 KB, patch)
2011-09-27 12:38 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-09-27 12:36:02 PDT 
Add layout test for WaveShaperNode
Comment 1 Chris Rogers 2011-09-27 12:38:19 PDT 
Created attachment 108883 [details]
Patch
Comment 2 Chris Rogers 2011-09-27 12:39:44 PDT 
Please see the specification for WaveShaperNode for more background:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#WaveShaperNode-section
Comment 3 Kenneth Russell 2011-09-27 18:40:14 PDT 
Comment on attachment 108883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108883&action=review

This looks great to me modulo one nit. These layout tests for the Web Audio API are looking really nice so far. r=me

> LayoutTests/webaudio/waveshaper.html:8
> +<script type="text/javascript" src="resources/buffer-loader.js"></script>

I don't think this file is needed.
Comment 4 WebKit Review Bot 2011-09-27 19:57:57 PDT 
Comment on attachment 108883 [details]
Patch

Clearing flags on attachment: 108883

Committed r96182: <http://trac.webkit.org/changeset/96182>
Comment 5 WebKit Review Bot 2011-09-27 19:58:01 PDT 
All reviewed patches have been landed.  Closing bug.