Bug 68924 - [WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
Summary: [WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextI...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on:
Blocks: 42337 66561
  Show dependency tree / graph
 
Reported: 2011-09-27 12:02 PDT by Chang Shu
Modified: 2011-10-05 12:45 PDT (History)
3 users (show)

See Also:

Attachments
patch 1 (30.55 KB, patch)
2011-09-29 07:22 PDT, Chang Shu 		darin: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch 2: rebase (30.77 KB, patch)
2011-10-05 11:52 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2011-09-27 12:02:36 PDT 
Support the above functions for TextInputController
Comment 1 Chang Shu 2011-09-29 07:22:13 PDT 
Created attachment 109161 [details]
patch 1
Comment 2 Chang Shu 2011-10-03 13:20:58 PDT 
ping reviewer. :)
Comment 3 Chang Shu 2011-10-05 10:44:19 PDT 
Darin, would you review this when you get a chance? thx!
Comment 4 Chang Shu 2011-10-05 11:19:43 PDT 
Comment on attachment 109161 [details]
patch 1

thanks!
Comment 5 WebKit Review Bot 2011-10-05 11:21:35 PDT 
Comment on attachment 109161 [details]
patch 1

Rejecting attachment 109161 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Bindings/TextInputController.idl
patching file Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro
patching file Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj
patching file Tools/WebKitTestRunner/win/InjectedBundle.vcproj
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/wk2/Skipped

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/9954521
Comment 6 Chang Shu 2011-10-05 11:52:16 PDT 
Created attachment 109830 [details]
patch 2: rebase
Comment 7 WebKit Review Bot 2011-10-05 12:45:47 PDT 
Comment on attachment 109830 [details]
patch 2: rebase

Clearing flags on attachment: 109830

Committed r96740: <http://trac.webkit.org/changeset/96740>
Comment 8 WebKit Review Bot 2011-10-05 12:45:54 PDT 
All reviewed patches have been landed.  Closing bug.