Bug 68914 - Clean up how FrameView accesses the RenderView
Summary: Clean up how FrameView accesses the RenderView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-27 10:42 PDT by Simon Fraser (smfr)
Modified: 2011-09-27 10:54 PDT (History)
2 users (show)

See Also:


Attachments
Patch (19.38 KB, patch)
2011-09-27 10:50 PDT, Simon Fraser (smfr)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-09-27 10:42:23 PDT
FrameView uses several different ways to get at the frame's root RenderView, and some of the null-check, others do not. This can cause crashes (e.g. bug 68893).
Comment 1 Simon Fraser (smfr) 2011-09-27 10:50:10 PDT
Created attachment 108868 [details]
Patch
Comment 2 Simon Fraser (smfr) 2011-09-27 10:54:12 PDT
http://trac.webkit.org/changeset/96130