Bug 68887 – method/enctype/formMethod/formEnctype properties should be limited to known values

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

These IDL attributes are defined as "limited to only known values".

http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#dom-fs-method
http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#dom-fs-formmethod


How to see the problem:
1. Visit http://samples.msdn.microsoft.com/ietestcenter/html5/forms_harness.htm?url=formenctype4
2. You'll see the following tests fail:
  - verify default value for formEnctype
  - verify default value for formMethod

[Kent Tamura]

Created attachment 108950 [details]
Patch

[Kent Tamura]

Comment on attachment 108950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108950&action=review

> Source/WebCore/loader/FormSubmission.h:63
> -        void parseMethodType(const String&);
> +        static Method parseMethodType(const String&);
> +        void updateMethodType(const String&);
> +        static String methodString(Method method) { return method == GetMethod ? "get" : "post"; }

I'm not satisfied with these function names. Any other ides?

> Source/WebCore/loader/FormSubmission.h:73
> -        void parseEncodingType(const String&);
> +        static String parseEncodingType(const String&);
> +        void updateEncodingType(const String&);

ditto.

[Vineet Chaudhary (vineetc)]

View in context: https://bugs.webkit.org/attachment.cgi?id=108950&action=review

>> Source/WebCore/loader/FormSubmission.h:63
>> +        static String methodString(Method method) { return method == GetMethod ? "get" : "post"; }

I am not reviewer, but here are my observation:

though methodString gets its argument from parseMethodType() which will always return GetMethod for any invalid/null value but as this is static method having,
static String methodString(Method method) { return method == PostMethod ? "post" : "get"; }  would be much safer. 

Also just a suggestion can we have GET/POST instead of get/post.
//Sorry if I am wrong..

[Kent Tamura]

(In reply to comment #3)
> though methodString gets its argument from parseMethodType() which will always return GetMethod for any invalid/null value but as this is static method having,
> static String methodString(Method method) { return method == PostMethod ? "post" : "get"; }  would be much safer. 

I would be better.  Thank you!

> Also just a suggestion can we have GET/POST instead of get/post.
> //Sorry if I am wrong..

No. The standard, Firefox 6, and IE8 normalize them to get/post, not GET/POST.

[Kent Tamura]

(In reply to comment #4)
> I would be better.  Thank you!

I -> It

[Hajime Morrita]

Comment on attachment 108950 [details]
Patch

It looks introducing an enum similar to FormSubmission::Method can be good idea. Maybe it's overkill though.

[Kent Tamura]

Created attachment 109439 [details]
Patch for landing

Update methodString() for Vineet's comment

[WebKit Review Bot]

Comment on attachment 109439 [details]
Patch for landing

Clearing flags on attachment: 109439

Committed r96484: <http://trac.webkit.org/changeset/96484>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.