Bug 68883 - Implement a MessageEvent constructor for JSC
Summary: Implement a MessageEvent constructor for JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 67824
  Show dependency tree / graph
 
Reported: 2011-09-27 02:45 PDT by Kentaro Hara
Modified: 2011-10-11 18:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (38.95 KB, patch)
2011-09-27 03:16 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Rebased patch (39.01 KB, patch)
2011-09-27 05:59 PDT, Kentaro Hara 		abarth: review+
Details | Formatted Diff | Diff
patch for commit (38.94 KB, patch)
2011-09-27 18:24 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-09-27 02:45:29 PDT 
MessageEvent should have a constructor (Spec: http://www.whatwg.org/specs/web-apps/current-work/#messageevent). 

After this patch is landed, I will add the MessageEvent constructor for V8 as a follow-up patch.
Comment 1 Kentaro Hara 2011-09-27 03:16:08 PDT 
Created attachment 108821 [details]
Patch
Comment 2 WebKit Review Bot 2011-09-27 03:20:26 PDT 
Attachment 108821 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

ERROR: FAILURES FOR <lucid, x86_64, release, cpu>
ERROR: Line:3791 Path does not exist. ast/canvas/webgl/premultiplyalpha-test.html
LayoutTests/platform/chromium/test_expectations.txt:3791:  Path does not exist. ast/canvas/webgl/premultiplyalpha-test.html  [test/expectations] [2]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kentaro Hara 2011-09-27 05:59:06 PDT 
Created attachment 108832 [details]
Rebased patch
Comment 4 Kentaro Hara 2011-09-27 18:24:26 PDT 
Created attachment 108947 [details]
patch for commit
Comment 5 WebKit Review Bot 2011-09-27 19:01:24 PDT 
Comment on attachment 108947 [details]
patch for commit

Clearing flags on attachment: 108947

Committed r96179: <http://trac.webkit.org/changeset/96179>