RESOLVED FIXED Bug 68870
[Qt] Test drivers should handle repaint rects 
https://bugs.webkit.org/show_bug.cgi?id=68870
Summary [Qt] Test drivers should handle repaint rects
Csaba Osztrogonác
Reported 2011-09-26 23:07:52 PDT
See this for details: http://trac.webkit.org/changeset/96005/trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp
Attachments
Patch (362.30 KB, patch)
2012-10-03 05:00 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (362.28 KB, patch)
2012-10-03 05:03 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (362.24 KB, patch)
2012-10-03 05:55 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (362.12 KB, patch)
2012-10-03 06:19 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (374.14 KB, patch)
2012-10-04 02:40 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
pixel diffs (deleted)
2012-10-08 07:29 PDT, Csaba Osztrogonác 		no flags
Details
patch (deleted)
2012-10-10 06:58 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2012-10-03 05:00:31 PDT
Created attachment 166857 [details] Patch
Balazs Kelemen
Comment 2 2012-10-03 05:03:50 PDT
Created attachment 166858 [details] Patch with the new title
Early Warning System Bot
Comment 3 2012-10-03 05:34:18 PDT
Comment on attachment 166858 [details] Patch Attachment 166858 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14152084
Balazs Kelemen
Comment 4 2012-10-03 05:55:25 PDT
Created attachment 166872 [details] Patch
Early Warning System Bot
Comment 5 2012-10-03 06:12:15 PDT
Comment on attachment 166872 [details] Patch Attachment 166872 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14130734
Balazs Kelemen
Comment 6 2012-10-03 06:19:52 PDT
Created attachment 166875 [details] Patch
Balazs Kelemen
Comment 7 2012-10-03 13:16:00 PDT
Comment on attachment 166875 [details] Patch This will probably need another rebaseline now that mock scrollbars have been enabled for Qt.
Balazs Kelemen
Comment 8 2012-10-04 02:40:58 PDT
Created attachment 167060 [details] Patch
Csaba Osztrogonác
Comment 9 2012-10-08 07:29:36 PDT
Created attachment 167538 [details] pixel diffs I ran a "quick" test with your patch, but it seems we need more rebaseline. I did the following things: - run-webkit-tests --qt -p --new-baseline --additional-platform-directory=LayoutTests/platform/qt-5.0-wk1 - apply your patch && build-webkit - run-webkit-tests --qt -p I got 303 failing tests and attached the layout-test-results directory. You can simple do the rebaseline with webkit-patch rebaseline-server.
Zoltan Herczeg
Comment 10 2012-10-10 06:24:56 PDT
Comment on attachment 167060 [details] Patch nice patch. r=me
Balazs Kelemen
Comment 11 2012-10-10 06:50:43 PDT
Comment on attachment 167060 [details] Patch Oops, sorry, this was an out of date version. We need more rebaseline.
Balazs Kelemen
Comment 12 2012-10-10 06:58:45 PDT
Created attachment 167993 [details] patch
Balazs Kelemen
Comment 13 2012-10-10 07:26:06 PDT
Comment on attachment 167993 [details] patch Clearing flags on attachment: 167993 Committed r130898: <http://trac.webkit.org/changeset/130898>
Balazs Kelemen
Comment 14 2012-10-10 07:26:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.