RESOLVED FIXED Bug 68868
Slightly improve performance of CSSStyleApplyProperty handler lookup. 
https://bugs.webkit.org/show_bug.cgi?id=68868
Summary Slightly improve performance of CSSStyleApplyProperty handler lookup.
Luke Macpherson
Reported 2011-09-26 22:28:32 PDT
Slightly improve performance of CSSStyleApplyProperty handler lookup.
Attachments
Patch (3.57 KB, patch)
2011-09-26 22:31 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2011-09-26 22:31:01 PDT
Created attachment 108787 [details] Patch
Luke Macpherson
Comment 2 2011-09-26 22:32:47 PDT
Shaves a few percent off the time spent in applyProperty() (measured using Shark profiler), and as a nice side effect makes it easier to see where time is spent when profiling.
Eric Seidel (no email)
Comment 3 2011-09-27 00:24:52 PDT
Comment on attachment 108787 [details] Patch Yay for avoiding double lookups! Can you please explain what test you used to show that this was faster?
Luke Macpherson
Comment 4 2011-09-27 15:28:35 PDT
Not a test as such, I was using the profiler (shark) and digging in the disassembled output to see where time was going and could see that the cost of the lookup was contributing more than necessary.
WebKit Review Bot
Comment 5 2011-09-27 16:24:00 PDT
Comment on attachment 108787 [details] Patch Clearing flags on attachment: 108787 Committed r96168: <http://trac.webkit.org/changeset/96168>
WebKit Review Bot
Comment 6 2011-09-27 16:24:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.