Bug 68868 - Slightly improve performance of CSSStyleApplyProperty handler lookup.
Summary: Slightly improve performance of CSSStyleApplyProperty handler lookup.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-26 22:28 PDT by Luke Macpherson
Modified: 2011-09-27 16:24 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.57 KB, patch)
2011-09-26 22:31 PDT, Luke Macpherson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2011-09-26 22:28:32 PDT
Slightly improve performance of CSSStyleApplyProperty handler lookup.
Comment 1 Luke Macpherson 2011-09-26 22:31:01 PDT
Created attachment 108787 [details]
Patch
Comment 2 Luke Macpherson 2011-09-26 22:32:47 PDT
Shaves a few percent off the time spent in applyProperty() (measured using Shark profiler), and as a nice side effect makes it easier to see where time is spent when profiling.
Comment 3 Eric Seidel (no email) 2011-09-27 00:24:52 PDT
Comment on attachment 108787 [details]
Patch

Yay for avoiding double lookups!  Can you please explain what test you used to show that this was faster?
Comment 4 Luke Macpherson 2011-09-27 15:28:35 PDT
Not a test as such, I was using the profiler (shark) and digging in the disassembled output to see where time was going and could see that the cost of the lookup was contributing more than necessary.
Comment 5 WebKit Review Bot 2011-09-27 16:24:00 PDT
Comment on attachment 108787 [details]
Patch

Clearing flags on attachment: 108787

Committed r96168: <http://trac.webkit.org/changeset/96168>
Comment 6 WebKit Review Bot 2011-09-27 16:24:04 PDT
All reviewed patches have been landed.  Closing bug.