Bug 68867 - [EFL] Remove *void* parameter in internal functions
Summary: [EFL] Remove *void* parameter in internal functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 68209
  Show dependency treegraph
 
Reported: 2011-09-26 22:05 PDT by Gyuyoung Kim
Modified: 2011-10-12 18:56 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.00 KB, patch)
2011-09-27 20:46 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2011-09-26 22:05:54 PDT
As one among efforts which are more compliant with WebKit coding style, we need to remove *void* parameter in internal functions. But, it looks we need to discuss to remove *void* parameter in public functions further.
Comment 1 Lucas De Marchi 2011-09-27 02:36:13 PDT
(In reply to comment #0)
> As one among efforts which are more compliant with WebKit coding style, we need to remove *void* parameter in internal functions. But, it looks we need to discuss to remove *void* parameter in public functions further.

We *can't* remove void on public headers. Please, do it only for internal ones.
Comment 2 Gyuyoung Kim 2011-09-27 20:46:58 PDT
Created attachment 108956 [details]
Patch
Comment 3 Gyuyoung Kim 2011-09-27 20:47:59 PDT
Ok, this patch is only related to internal functions.
Comment 4 Lucas De Marchi 2011-09-27 21:44:43 PDT
Comment on attachment 108956 [details]
Patch

informal r+
Comment 5 WebKit Review Bot 2011-09-28 05:34:27 PDT
Comment on attachment 108956 [details]
Patch

Clearing flags on attachment: 108956

Committed r96217: <http://trac.webkit.org/changeset/96217>
Comment 6 WebKit Review Bot 2011-09-28 05:34:31 PDT
All reviewed patches have been landed.  Closing bug.