Bug 68862 – [chromium] Allow building webkit for linux without GTK

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit Misc.

[Sadrul Habib Chowdhury]

Webkit needs to be buildable without GTK for linux. (as part for the no-gtk effort for ChromeOS).

[Sadrul Habib Chowdhury]

Created attachment 108779 [details]
patch

[Sadrul Habib Chowdhury]

Created attachment 108783 [details]
patch

[WebKit Review Bot]

Attachment 108783 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit/chromium/src/linux/WebFontInfo.cpp:32:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sadrul Habib Chowdhury]

Created attachment 108851 [details]
fixed style

The following patch is required for chromium:


diff --git a/content/browser/renderer_host/render_sandbox_host_linux.cc b/content/browser/renderer_host/render_sandbox_host_linux.cc
index 3363a3b..0ce5d88 100644
--- a/content/browser/renderer_host/render_sandbox_host_linux.cc
+++ b/content/browser/renderer_host/render_sandbox_host_linux.cc
@@ -32,7 +32,7 @@
 #include "skia/ext/SkFontHost_fontconfig_direct.h"
 #include "third_party/npapi/bindings/npapi_extensions.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebKit.h"
-#include "third_party/WebKit/Source/WebKit/chromium/public/gtk/WebFontInfo.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/linux/WebFontInfo.h"
 #include "webkit/glue/webkitplatformsupport_impl.h"
 
 using WebKit::WebCString;


Is this something I need to coordinate with the gardener, or is there some other way?

[Adam Barth]

> Is this something I need to coordinate with the gardener, or is there some other way?

Can you add a placeholder header that just includes the other header?  After the roll, you can apply your Chromium patch and then delete the placeholder header.

We need fishd to review this patch because it changes the WebKit API.

[Sadrul Habib Chowdhury]

Created attachment 108880 [details]
add a placeholder file

Added a placeholder file, to be removed after gardening and landing the change in chromium to update the include path. Thanks!

[WebKit Review Bot]

Attachment 108880 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit/chromium/public/gtk/WebFontInfo.h:31:  #ifndef header guard has wrong style, please use: WebFontInfo_h  [build/header_guard] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sadrul Habib Chowdhury]

(In reply to comment #7)
> Attachment 108880 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> 
> Source/WebKit/chromium/public/gtk/WebFontInfo.h:31:  #ifndef header guard has wrong style, please use: WebFontInfo_h  [build/header_guard] [5]
> Total errors found: 1 in 7 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

The style nit is necessary in this case to make sure the correct file gets #includ'ed. Since this is a temporary placeholder file that will be removed anyway, perhaps this style error is OK?

[WebKit Review Bot]

Comment on attachment 108880 [details]
add a placeholder file

Rejecting attachment 108880 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t 1.
Hunk #2 FAILED at 28.
2 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/chromium/public/gtk/WebFontInfo.h.rej
patching file Source/WebKit/chromium/public/linux/WebFontInfo.h
patching file Source/WebKit/chromium/src/gtk/WebFontInfo.cpp
rm 'Source/WebKit/chromium/src/gtk/WebFontInfo.cpp'
patching file Source/WebKit/chromium/src/linux/WebFontInfo.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Fisher', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/9881812

[Sadrul Habib Chowdhury]

Unfortunately, there was some miscommunication, and another CL went in (https://bugs.webkit.org/show_bug.cgi?id=68936) that included some of the changes here. However, the landed CL was incomplete: it only moves WebFontInfo.h out of gtk/ into linux/ but not the corresponding .cpp file. So I will change this CL to do just that and resubmit for review.

[WebKit Review Bot]

Comment on attachment 108880 [details]
add a placeholder file

Rejecting attachment 108880 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
next patch would delete the file Source/WebKit/chromium/src/gtk/WebFontInfo.cpp,
which does not exist!  Applying it anyway.
patching file Source/WebKit/chromium/src/gtk/WebFontInfo.cpp
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/src/gtk/WebFontInfo.cpp.rej
patching file Source/WebKit/chromium/src/linux/WebFontInfo.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Fisher', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/10981185

[Stephen Chenney]

Marking test failures as WontFix. Bug is still accessible and recording in TestExpectations.