RESOLVED FIXED Bug 68838
[chromium] Work around null render surface crash in updateCompositorResources 
https://bugs.webkit.org/show_bug.cgi?id=68838
Summary [chromium] Work around null render surface crash in updateCompositorResources
Adrienne Walker
Reported 2011-09-26 15:06:29 PDT
[chromium] Work around null render surface crash in updateCompositorResources
Attachments
Patch (1.42 KB, patch)
2011-09-26 15:09 PDT, Adrienne Walker 		jamesr: review+
jamesr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2011-09-26 15:09:33 PDT
Created attachment 108728 [details] Patch
Adrienne Walker
Comment 2 2011-09-26 15:15:44 PDT
I plan to land this on the 874 branch. Bugzilla's not really equipped to make that obvious. An alternate approach would have been to clear m_updateList in setRootLayer, since this is the place where render surfaces are cleared. Or, since m_updateList is in use in paintLayers, mark some flag that it needed to be cleared, since it's in use in that function. However, I wanted something simple on the branch so it only had to be fixed once, so I just added a conditional check.
James Robinson
Comment 3 2011-09-26 15:19:47 PDT
Comment on attachment 108728 [details] Patch R=me for branch (not trunk)
Adrienne Walker
Comment 4 2011-09-26 16:03:34 PDT
Committed manually on the 874 branch in: http://trac.webkit.org/changeset/96022. See also: http://code.google.com/p/chromium/issues/detail?id=96719
Note You need to log in before you can comment on or make changes to this bug.