Bug 68838 - [chromium] Work around null render surface crash in updateCompositorResources
Summary: [chromium] Work around null render surface crash in updateCompositorResources
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
Depends on:
Reported: 2011-09-26 15:06 PDT by Adrienne Walker
Modified: 2011-09-26 16:03 PDT (History)
2 users (show)

See Also:

Patch (1.42 KB, patch)
2011-09-26 15:09 PDT, Adrienne Walker
jamesr: review+
jamesr: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-09-26 15:06:29 PDT
[chromium] Work around null render surface crash in updateCompositorResources
Comment 1 Adrienne Walker 2011-09-26 15:09:33 PDT
Created attachment 108728 [details]
Comment 2 Adrienne Walker 2011-09-26 15:15:44 PDT
I plan to land this on the 874 branch.  Bugzilla's not really equipped to make that obvious.

An alternate approach would have been to clear m_updateList in setRootLayer, since this is the place where render surfaces are cleared.  Or, since m_updateList is in use in paintLayers, mark some flag that it needed to be cleared, since it's in use in that function.  However, I wanted something simple on the branch so it only had to be fixed once, so I just added a conditional check.
Comment 3 James Robinson 2011-09-26 15:19:47 PDT
Comment on attachment 108728 [details]

R=me for branch (not trunk)
Comment 4 Adrienne Walker 2011-09-26 16:03:34 PDT
Committed manually on the 874 branch in: http://trac.webkit.org/changeset/96022.

See also: http://code.google.com/p/chromium/issues/detail?id=96719