Bug 68837 - [GTK] Do not ignore 'Replaceable' attributes in the DOM bindings
Summary: [GTK] Do not ignore 'Replaceable' attributes in the DOM bindings
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-09-26 14:46 PDT by Xan Lopez
Modified: 2011-09-26 21:21 PDT (History)
2 users (show)

See Also:

replaceable.diff (3.53 KB, patch)
2011-09-26 15:10 PDT, Xan Lopez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2011-09-26 14:46:59 PDT
We are ignoring all attributes with this tag, but we shouldn't. Worst case they should be readable, which is what this patch does. In the future we should probably actually allow them to be replaced, with some kind of custom code.
Comment 1 Xan Lopez 2011-09-26 15:10:52 PDT
Created attachment 108729 [details]
Comment 2 Martin Robinson 2011-09-26 15:13:31 PDT
Comment on attachment 108729 [details]

Looks good. Better open abug for the the FIXME.
Comment 3 Xan Lopez 2011-09-26 15:27:32 PDT
Comment on attachment 108729 [details]

Clearing flags on attachment: 108729

Committed r96009: <http://trac.webkit.org/changeset/96009>
Comment 4 Xan Lopez 2011-09-26 15:27:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Sam Weinig 2011-09-26 21:21:19 PDT
Replaceable (as far as I can remember) is really is only there to support the fact that the DOMWindow is also the global object, so it probably doesn't makes sense outside of JavaScript.