Bug 68818 - IndexedDB: Second half of IDBFactory.getDatabaseNames implementation
Summary: IndexedDB: Second half of IDBFactory.getDatabaseNames implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-26 11:38 PDT by Joshua Bell
Modified: 2011-09-26 17:42 PDT (History)
4 users (show)

See Also:


Attachments
Patch (36.40 KB, patch)
2011-09-26 11:41 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff
Patch (36.42 KB, patch)
2011-09-26 14:44 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2011-09-26 11:38:15 PDT
IndexedDB: Second half of IDBFactory.getDatabaseNames implementation
Comment 1 Joshua Bell 2011-09-26 11:41:50 PDT
Created attachment 108697 [details]
Patch
Comment 2 Joshua Bell 2011-09-26 11:44:55 PDT
First half was landed as https://bugs.webkit.org/show_bug.cgi?id=68037 - initial patches there contained both halves, which received review.
Comment 3 David Grogan 2011-09-26 11:59:13 PDT
Comment on attachment 108697 [details]
Patch

LGTM, assuming it's unchanged from the other bug.
Comment 4 Joshua Bell 2011-09-26 12:35:30 PDT
Tony - another one for you to poke at with a stick.
Comment 5 Tony Chang 2011-09-26 13:49:03 PDT
Comment on attachment 108697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108697&action=review

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:63
> +
> +

Nit: Did you mean to add this whitespace?
Comment 6 Joshua Bell 2011-09-26 14:44:33 PDT
Created attachment 108726 [details]
Patch
Comment 7 WebKit Review Bot 2011-09-26 17:42:09 PDT
Comment on attachment 108726 [details]
Patch

Clearing flags on attachment: 108726

Committed r96054: <http://trac.webkit.org/changeset/96054>
Comment 8 WebKit Review Bot 2011-09-26 17:42:14 PDT
All reviewed patches have been landed.  Closing bug.