Bug 68809 - IconDatabase::syncThreadMainLoop can assert if wakeSyncThread is called before thread starts executing
Summary: IconDatabase::syncThreadMainLoop can assert if wakeSyncThread is called befor...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2011-09-26 09:40 PDT by Mark Rowe (bdash)
Modified: 2011-09-26 10:35 PDT (History)
4 users (show)

See Also:


Attachments
Untested patch (874 bytes, patch)
2011-09-26 09:42 PDT, Mark Rowe (bdash)
no flags Details | Formatted Diff | Diff
Patch v1 (3.12 KB, patch)
2011-09-26 10:03 PDT, Mark Rowe (bdash)
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2011-09-26 09:40:27 PDT
As in summary.  This is a regression from r95929 / bug 68783.
Comment 1 Mark Rowe (bdash) 2011-09-26 09:42:43 PDT
Created attachment 108679 [details]
Untested patch

This is an untested patch that I believe will address the issue.  I’m putting it up as it may be a few hours before I’m able to test the patch, and it may be useful for anyone being troubled by the assertion.
Comment 2 Mark Rowe (bdash) 2011-09-26 10:03:22 PDT
Created attachment 108683 [details]
Patch v1

Dan says that this addressed the issue for him, so I’m putting it up for review.
Comment 3 Mark Rowe (bdash) 2011-09-26 10:35:25 PDT
Fixed in r95961.