[skia] need rebaseline after the next skia roll -- improvedments to xfermodes on gpu
Created attachment 108674 [details] Patch
Comment on attachment 108674 [details] Patch They only need a rebaseline on linux? What about mac or windows? If they only need a rebaseline in GPU mode, you can add the 'GPU' modifier.
Created attachment 108682 [details] Patch
updated expectations to specify GPU
This says GPU but I still have no idea why this would be linux-specific. Mind explaining that?
Comment on attachment 108682 [details] Patch Looks good. r=me
Sorry, didn't see James's comments until I r+'ed it. Well, I leave it up to your discretion. If you break it, you bought it. :)
I ran DRT locally on windows and linux, and only saw the problem on linux. I can be more conservative next time, and just say GPU.
(In reply to comment #8) > I ran DRT locally on windows and linux, and only saw the problem on linux. I can be more conservative next time, and just say GPU. OK, that's fine. There's no way for me to know that you had done that unless you let me know somehow, or say so in the ChangeLog.
I wouldn't have know which ones to rebaseline, if I hadn't run locally. That said, it is odd that I didn't see any failures when I ran on Windows. Who knows, I may have just screwed up and missed them (gulp).
¯\(°_o)/¯ let's see what the bots says, then.
Comment on attachment 108682 [details] Patch Clearing flags on attachment: 108682 Committed r96006: <http://trac.webkit.org/changeset/96006>
All reviewed patches have been landed. Closing bug.