Bug 68807 - [skia] need rebaseline after the next skia roll -- improvements to xfermodes on gpu
Summary: [skia] need rebaseline after the next skia roll -- improvements to xfermodes ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Reed
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-26 09:08 PDT by Mike Reed
Modified: 2011-09-26 15:20 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.43 KB, patch)
2011-09-26 09:08 PDT, Mike Reed
no flags Details | Formatted Diff | Diff
Patch (1.45 KB, patch)
2011-09-26 09:58 PDT, Mike Reed
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reed 2011-09-26 09:08:09 PDT
[skia] need rebaseline after the next skia roll -- improvedments to xfermodes on gpu
Comment 1 Mike Reed 2011-09-26 09:08:49 PDT
Created attachment 108674 [details]
Patch
Comment 2 James Robinson 2011-09-26 09:30:43 PDT
Comment on attachment 108674 [details]
Patch

They only need a rebaseline on linux? What about mac or windows?

If they only need a rebaseline in GPU mode, you can add the 'GPU' modifier.
Comment 3 Mike Reed 2011-09-26 09:58:37 PDT
Created attachment 108682 [details]
Patch
Comment 4 Mike Reed 2011-09-26 09:59:06 PDT
updated expectations to specify GPU
Comment 5 James Robinson 2011-09-26 13:53:28 PDT
This says GPU but I still have no idea why this would be linux-specific.  Mind explaining that?
Comment 6 Stephen White 2011-09-26 14:02:47 PDT
Comment on attachment 108682 [details]
Patch

Looks good.  r=me
Comment 7 Stephen White 2011-09-26 14:03:57 PDT
Sorry, didn't see James's comments until I r+'ed it.  Well, I leave it up to your discretion.  If you break it, you bought it.  :)
Comment 8 Mike Reed 2011-09-26 14:16:16 PDT
I ran DRT locally on windows and linux, and only saw the problem on linux. I can be more conservative next time, and just say GPU.
Comment 9 James Robinson 2011-09-26 14:25:38 PDT
(In reply to comment #8)
> I ran DRT locally on windows and linux, and only saw the problem on linux. I can be more conservative next time, and just say GPU.

OK, that's fine.  There's no way for me to know that you had done that unless you let me know somehow, or say so in the ChangeLog.
Comment 10 Mike Reed 2011-09-26 14:32:52 PDT
I wouldn't have know which ones to rebaseline, if I hadn't run locally. That said, it is odd that I didn't see any failures when I ran on Windows. Who knows, I may have just screwed up and missed them (gulp).
Comment 11 James Robinson 2011-09-26 14:50:31 PDT
¯\(°_o)/¯ let's see what the bots says, then.
Comment 12 WebKit Review Bot 2011-09-26 15:20:11 PDT
Comment on attachment 108682 [details]
Patch

Clearing flags on attachment: 108682

Committed r96006: <http://trac.webkit.org/changeset/96006>
Comment 13 WebKit Review Bot 2011-09-26 15:20:16 PDT
All reviewed patches have been landed.  Closing bug.