RESOLVED FIXED Bug 68800
Web Inspector: introduce protocol backwards compatibility validator. 
https://bugs.webkit.org/show_bug.cgi?id=68800
Summary Web Inspector: introduce protocol backwards compatibility validator.
Pavel Feldman
Reported 2011-09-26 06:34:15 PDT
Patch to follow.
Attachments
Patch (9.53 KB, patch)
2011-09-26 06:40 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] Same with the draft-01 to validate against. (120.41 KB, patch)
2011-09-26 06:59 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] Review comments addressed (120.80 KB, patch)
2011-09-26 07:54 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-09-26 06:40:25 PDT
Created attachment 108660 [details] Patch
Pavel Feldman
Comment 2 2011-09-26 06:59:42 PDT
Created attachment 108663 [details] [Patch] Same with the draft-01 to validate against.
Yury Semikhatsky
Comment 3 2011-09-26 07:26:00 PDT
Comment on attachment 108663 [details] [Patch] Same with the draft-01 to validate against. View in context: https://bugs.webkit.org/attachment.cgi?id=108663&action=review > Source/WebCore/inspector/validate-protocol-compatibility:31 > + Please add a definition of what valid protocol change is, also would be nice to have several tests for invalid cases. > Source/WebCore/inspector/validate-protocol-compatibility:162 > + json_string = json_string.replace(": true", ": True") what about :true and :false cases(without whitespace)? > Source/WebCore/inspector/validate-protocol-compatibility:168 > + print "Usage: validate-protocol-compatibility Inspector.draft-01.json Inspector.json" validate-protocol-compatibility -> sys.argv[0]
Pavel Feldman
Comment 4 2011-09-26 07:54:22 PDT
Created attachment 108667 [details] [Patch] Review comments addressed
Yury Semikhatsky
Comment 5 2011-09-26 08:03:23 PDT
Comment on attachment 108667 [details] [Patch] Review comments addressed Please add inline self-test as we agreed offline.
Pavel Feldman
Comment 6 2011-09-26 08:28:53 PDT
Committed r95953: <http://trac.webkit.org/changeset/95953>
Note You need to log in before you can comment on or make changes to this bug.