Bug 68780 - [Qt]REGRESSION(r95865): It made 4 tests crash
Summary: [Qt]REGRESSION(r95865): It made 4 tests crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 68717
  Show dependency treegraph
 
Reported: 2011-09-25 14:45 PDT by Csaba Osztrogonác
Modified: 2011-09-26 11:51 PDT (History)
6 users (show)

See Also:


Attachments
array-type-speculation-crash-log.txt (6.90 KB, text/plain)
2011-09-25 14:51 PDT, Csaba Osztrogonác
no flags Details
Patch (2.28 KB, patch)
2011-09-26 08:07 PDT, Zoltan Herczeg
oliver: review+
oliver: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-09-25 14:45:20 PDT
fast/js/array-type-speculation.html
fast/js/exception-expression-offset.html
fast/js/trivial-functions.html
sputnik/Conformance/15_Native_Objects/15.8_Math/15.8.2/15.8.2.13_pow/S15.8.2.13_A23.html
Comment 1 Csaba Osztrogonác 2011-09-25 14:51:27 PDT
Created attachment 108612 [details]
array-type-speculation-crash-log.txt
Comment 2 Geoffrey Garen 2011-09-25 20:10:05 PDT
Is this Qt-only?

Is this still happening after http://trac.webkit.org/changeset/95918?
Comment 3 Csaba Osztrogonác 2011-09-25 22:47:00 PDT
(In reply to comment #2)
> Is this Qt-only?
It seems yes.
 
> Is this still happening after http://trac.webkit.org/changeset/95918?
Yes. And unfortunately after 95517 there are additionl crashes:
https://bugs.webkit.org/show_bug.cgi?id=68788
Comment 4 Zoltan Herczeg 2011-09-26 06:31:33 PDT
(Ossy why didn't you mention that it only appears on 32 bit?)
Comment 5 Zoltan Herczeg 2011-09-26 08:07:19 PDT
Created attachment 108669 [details]
Patch

All layouttests were not checked, hence I not yet set r+. Ossy could you help me?
Comment 6 Csaba Osztrogonác 2011-09-26 10:17:49 PDT
Comment on attachment 108669 [details]
Patch

I tested it, and it fixes these 4 broken tests.
Comment 7 WebKit Review Bot 2011-09-26 11:26:18 PDT
Comment on attachment 108669 [details]
Patch

Rejecting attachment 108669 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
a52d50ddf19950afd9de88f49c3e0998eb480138
r95963 = dce2c7474952b6269ac032b633c66c1dc0c45118
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9843900
Comment 8 Oliver Hunt 2011-09-26 11:27:44 PDT
Comment on attachment 108669 [details]
Patch

Novel decision to remove a JSC patch from the commit-queue because the chrome build fails...
Comment 9 Geoffrey Garen 2011-09-26 11:51:08 PDT
Committed revision 95965.