Bug 68766 - JIT implementation of put_by_val increments m_length instead of setting it to index+1
Summary: JIT implementation of put_by_val increments m_length instead of setting it to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-24 15:19 PDT by Filip Pizlo
Modified: 2011-09-24 19:19 PDT (History)
3 users (show)

See Also:


Attachments
the patch (1.44 KB, patch)
2011-09-24 15:21 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-09-24 15:19:32 PDT
This results in regressions in a variety of tests, including ./js1_6/Array/regress-290592.js.
Comment 1 Filip Pizlo 2011-09-24 15:21:48 PDT
Created attachment 108590 [details]
the patch
Comment 2 Geoffrey Garen 2011-09-24 16:10:08 PDT
Comment on attachment 108590 [details]
the patch

r=me
Comment 3 WebKit Review Bot 2011-09-24 19:19:48 PDT
Comment on attachment 108590 [details]
the patch

Clearing flags on attachment: 108590

Committed r95918: <http://trac.webkit.org/changeset/95918>
Comment 4 WebKit Review Bot 2011-09-24 19:19:52 PDT
All reviewed patches have been landed.  Closing bug.