Bug 68762 - REGRESSION (r95747): Activating the web inspector causes the web process to be killed
Summary: REGRESSION (r95747): Activating the web inspector causes the web process to b...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Alexey Proskuryakov
Keywords: Regression
Depends on:
Reported: 2011-09-24 13:22 PDT by Mark Rowe (bdash)
Modified: 2011-09-26 23:11 PDT (History)
5 users (show)

See Also:

proposed fix (8.10 KB, patch)
2011-09-26 12:10 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2011-09-24 13:22:45 PDT
2011-09-24 1:02:14.283 PM [0x0-0x1ab1ab].com.apple.Safari: Receive an invalid message from the web process with message ID 31e002d

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x00000000bbadbeef
0x0000000102afdcea in WebKit::WebPageProxy::decidePolicyForNavigationAction (this=0x109804600, frameID=3, opaqueNavigationType=5, opaqueModifiers=0, opaqueMouseButton=6357106, request=@0x7fff5fbfd9d0, listenerID=2, arguments=0x1129320e0, receivedPolicyAction=@0x7fff5fbfd998, policyAction=@0x7fff5fbfd9a0, downloadID=@0x7fff5fbfd9a8) at /Volumes/Data/Users/mrowe/Documents/Work/WebKit-git/OpenSource/Source/WebKit2/UIProcess/WebPageProxy.cpp:1795
1795	    MESSAGE_CHECK_URL(request.url());
(gdb) po request.url().createCFURL()
Comment 1 Adam Barth 2011-09-24 13:45:05 PDT
The way we solve this in Chromium is to use a URL scheme other that "file" for the web inspector.  For example, we used the scheme "inspector" at some point.  Now, I think we use "chrome", which is the scheme we use for a bunch of browser-provided HTML UI.
Comment 2 Mark Rowe (bdash) 2011-09-24 13:52:05 PDT
I’m pretty sure this is just an oversight in r95747 and that the code path that shows the inspector simply isn’t making the necessary call so that the MESSAGE_CHECK_URL call knows that the UI process initiated the load of the inspector.
Comment 3 Adam Barth 2011-09-24 13:58:28 PDT
Yep, that's another approach to solving this problem.
Comment 4 Alexey Proskuryakov 2011-09-24 21:33:35 PDT
As Mark says, WebInspectorProxy::createInspectorPage() should add WebCore resources folder to WebProcessProxy::m_localPathsWithAssumedReadAccess. I'll work on this ASAP (which might be Monday).
Comment 5 Alexey Proskuryakov 2011-09-26 12:10:30 PDT
Created attachment 108704 [details]
proposed fix
Comment 6 WebKit Review Bot 2011-09-26 15:45:38 PDT
Comment on attachment 108704 [details]
proposed fix

Clearing flags on attachment: 108704

Committed r96014: <http://trac.webkit.org/changeset/96014>
Comment 7 WebKit Review Bot 2011-09-26 15:45:44 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Csaba Osztrogonác 2011-09-26 23:11:45 PDT
Qt-WK2 buildfix landed in http://trac.webkit.org/changeset/96067