Bug 68755 - JSVALUE32_64 DFG JIT has bugs in GetById, PutById, and GetByOffset code generation
Summary: JSVALUE32_64 DFG JIT has bugs in GetById, PutById, and GetByOffset code gener...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-24 06:15 PDT by Yuqiang Xian
Modified: 2011-09-27 16:48 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch (14.58 KB, patch)
2011-09-24 06:25 PDT, Yuqiang Xian
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuqiang Xian 2011-09-24 06:15:47 PDT
In JSVALUE32_64 DFG JIT, we need to load/store and repatch both tag and payload of a property for GetById/PutById, and to reorder the loads of tag and payload for GetByOffset as the result tag GPR could reuse the storage GPR.
Comment 1 Yuqiang Xian 2011-09-24 06:25:23 PDT
Created attachment 108583 [details]
proposed patch
Comment 2 Gavin Barraclough 2011-09-27 16:48:17 PDT
Landed in r96171