Bug 68747 – Layout Test media/controls-right-click-on-timebar.html is flaky - Crash on LEOPARD CG DEBUG

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Mihai Parparita]

media/controls-right-click-on-timebar.html frequently times out on all platforms

See the Chromium flakiness dashboard:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Fcontrols-right-click-on-timebar.html&showExpectations=true&group=%40DEPS%20-%20chromium.org

Composite filter DCHECK

Chromium bug: http://code.google.com/p/chromium/issues/detail?id=96861

e:\b\build\slave\Webkit_Win__dbg__2_\build\src\webkit\support\webkit_support.cc(79): error: Failed
[10680:984:3509453:FATAL:composite_filter.cc(284)] Check failed: (status_cb_.is_null() && callback_.get()) || (!status_cb_.is_null() && !callback_.get()). 
Backtrace:
	base::debug::StackTrace::StackTrace [0x0089AF41+33] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\debug\stack_trace_win.cc:149)
	logging::LogMessage::~LogMessage [0x0088587F+63] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\logging.cc:561)
	media::CompositeFilter::DispatchPendingCallback [0x00E3FADA+218] (e:\b\build\slave\webkit_win__dbg__2_\build\src\media\base\composite_filter.cc:286)
	media::CompositeFilter::OnCallSequenceDone [0x00E3FF2E+110] (e:\b\build\slave\webkit_win__dbg__2_\build\src\media\base\composite_filter.cc:401)
	media::CompositeFilter::SerialCallback [0x00E3FD33+227] (e:\b\build\slave\webkit_win__dbg__2_\build\src\media\base\composite_filter.cc:352)
	DispatchToMethod<media::CompositeFilter,void (__thiscall media::CompositeFilter::*)(void)> [0x00E435EF+15] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\tuple.h:541)
	ScopedRunnableMethodFactory<media::CompositeFilter>::RunnableMethod<void (__thiscall media::CompositeFilter::*)(void),Tuple0>::Run [0x00E42AE0+64] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\task.h:163)
	media::CompositeFilter::OnCallback [0x00E40086+102] (e:\b\build\slave\webkit_win__dbg__2_\build\src\media\base\composite_filter.cc:431)
	DispatchToFunction<void (__cdecl*)(MessageLoop *,CancelableTask *),MessageLoop *,CancelableTask *> [0x00E43616+22] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\tuple.h:619)
	RunnableFunction<void (__cdecl*)(MessageLoop *,CancelableTask *),Tuple2<MessageLoop *,CancelableTask *> >::Run [0x00E42BAA+42] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\task.h:476)
	media::TaskToCallbackAdapter::RunWithParams [0x00E34A45+53] (e:\b\build\slave\webkit_win__dbg__2_\build\src\media\base\callback.cc:22)
	CallbackRunner<Tuple0>::Run [0x00B53160+48] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\callback_old.h:79)
	webkit_glue::VideoRendererImpl::OnStop [0x00B51D59+41] (e:\b\build\slave\webkit_win__dbg__2_\build\src\webkit\glue\media\video_renderer_impl.cc:36)
	media::VideoRendererBase::Stop [0x00E1DE22+194] (e:\b\build\slave\webkit_win__dbg__2_\build\src\media\filters\video_renderer_base.cc:92)
	media::CompositeFilter::CallFilter [0x00E3F8BE+222] (e:\b\build\slave\webkit_win__dbg__2_\build\src\media\base\composite_filter.cc:269)
	media::CompositeFilter::SerialCallback [0x00E3FDA3+339] (e:\b\build\slave\webkit_win__dbg__2_\build\src\media\base\composite_filter.cc:362)
	DispatchToMethod<media::CompositeFilter,void (__thiscall media::CompositeFilter::*)(void)> [0x00E435EF+15] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\tuple.h:541)
	ScopedRunnableMethodFactory<media::CompositeFilter>::RunnableMethod<void (__thiscall media::CompositeFilter::*)(void),Tuple0>::Run [0x00E42AE0+64] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\task.h:163)
	base::subtle::TaskClosureAdapter::Run [0x022BAB52+50] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\task.cc:56)
	base::internal::Invoker1<0,base::internal::InvokerStorage1<void (__thiscall base::subtle::TaskClosureAdapter::*)(void),base::subtle::TaskClosureAdapter *>,void (__thiscall base::subtle::TaskClosureAdapter::*)(void)>::DoInvoke [0x022B53AD+45] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\bind_internal.h:595)
	base::Callback<void __cdecl(void)>::Run [0x008B9D6F+47] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\callback.h:269)
	MessageLoop::RunTask [0x022ABA15+293] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\message_loop.cc:478)
	MessageLoop::DeferOrRunPendingTask [0x022ABB53+51] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\message_loop.cc:495)
	MessageLoop::DoWork [0x022AC52D+221] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\message_loop.cc:682)
	base::MessagePumpDefault::Run [0x02316E73+195] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\message_pump_default.cc:23)
	MessageLoop::RunInternal [0x022AB767+247] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\message_loop.cc:443)
	MessageLoop::RunHandler [0x022AB53E+46] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\message_loop.cc:417)
	MessageLoop::Run [0x022AAE4A+58] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\message_loop.cc:341)
	base::Thread::Run [0x022C26A6+22] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\threading\thread.cc:129)
	base::Thread::ThreadMain [0x022C2811+225] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\threading\thread.cc:163)
	base::`anonymous namespace'::ThreadFunc [0x008B8DB0+96] (e:\b\build\slave\webkit_win__dbg__2_\build\src\base\threading\platform_thread_win.cc:42)
	GetModuleFileNameA [0x7C80B729+442]

[Ami Fischman]

Should be fixed now (see CRBUG96861).
Kenji: can you rebaseline the test & resolve this bug?

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media/controls-right-click-on-timebar.html

shows TIMEOUT issue is fixed. But, I see different crash now.

/b/build/slave/webkit-mac-cg-latest-dbg/build/src/webkit/support/webkit_support.cc:79: Failure
Failed
[46273:58883:89418792797375:FATAL:ffmpeg_video_decoder.cc(186)] Check failed: state_ != kStopped (7 vs. 7)
Backtrace:
	0   DumpRenderTree                      0x744b132f _mh_execute_header + 21295
	1   DumpRenderTree                      0x744b12cb _mh_execute_header + 21195
	2   DumpRenderTree                      0x744b2dbc _mh_execute_header + 28092
	3   DumpRenderTree                      0x744b230b _mh_execute_header + 25355
	4   DumpRenderTree                      0x77814e38 start + 53622824
	5   DumpRenderTree                      0x77817a03 start + 53634035
	6   DumpRenderTree                      0x74ac496b start + 6107995
	7   DumpRenderTree                      0x74ac2002 start + 6097394
	8   DumpRenderTree                      0x74ac2251 start + 6097985
	9   DumpRenderTree                      0x74ac247d start + 6098541
	10  DumpRenderTree                      0x74ad4a5c start + 6173772
	11  DumpRenderTree                      0x74ac1893 start + 6095491
	12  DumpRenderTree                      0x74ac0cbb start + 6092459
	13  DumpRenderTree                      0x74ac0c00 start + 6092272
	14  DumpRenderTree                      0x74b595b2 start + 6717346
	15  DumpRenderTree                      0x74b59773 start + 6717795
	16  DumpRenderTree                      0x74b57a16 start + 6710278
	17  libSystem.B.dylib                   0x92c2f055 _pthread_start + 321
	18  libSystem.B.dylib                   0x92c2ef12 thread_start + 34


[46273:58883:89418793984386:FATAL:ffmpeg_video_decoder.cc(260)] Check failed: state_ != kStopped (7 vs. 7)
Backtrace:
	0   DumpRenderTree                      0x744b132f _mh_execute_header + 21295
	1   DumpRenderTree                      0x744b12cb _mh_execute_header + 21195
	2   DumpRenderTree                      0x744b2dbc _mh_execute_header + 28092
	3   DumpRenderTree                      0x744b230b _mh_execute_header + 25355
	4   DumpRenderTree                      0x778154be start + 53624494
	5   DumpRenderTree                      0x77815730 start + 53625120
	6   DumpRenderTree                      0x77827cdb start + 53700299
	7   DumpRenderTree                      0x77827727 start + 53698839
	8   DumpRenderTree                      0x77814f1b start + 53623051
	9   DumpRenderTree                      0x77817a03 start + 53634035
	10  DumpRenderTree                      0x74ac496b start + 6107995
	11  DumpRenderTree                      0x74ac2002 start + 6097394
	12  DumpRenderTree                      0x74ac2251 start + 6097985
	13  DumpRenderTree                      0x74ac247d start + 6098541
	14  DumpRenderTree                      0x74ad4a5c start + 6173772
	15  DumpRenderTree                      0x74ac1893 start + 6095491
	16  DumpRenderTree                      0x74ac0cbb start + 6092459
	17  DumpRenderTree                      0x74ac0c00 start + 6092272
	18  DumpRenderTree                      0x74b595b2 start + 6717346
	19  DumpRenderTree                      0x74b59773 start + 6717795
	20  DumpRenderTree                      0x74b57a16 start + 6710278
	21  libSystem.B.dylib                   0x92c2f055 _pthread_start + 321
	22  libSystem.B.dylib                   0x92c2ef12 thread_start + 34

/b/build/slave/webkit-mac-cg-latest-dbg/build/src/webkit/support/webkit_support.cc:79: Failure
Failed
[46273:58883:89418793984386:FATAL:ffmpeg_video_decoder.cc(260)] Check failed: state_ != kStopped (7 vs. 7)
Backtrace:
	0   DumpRenderTree                      0x744b132f _mh_execute_header + 21295
	1   DumpRenderTree                      0x744b12cb _mh_execute_header + 21195
	2   DumpRenderTree                      0x744b2dbc _mh_execute_header + 28092
	3   DumpRenderTree                      0x744b230b _mh_execute_header + 25355
	4   DumpRenderTree                      0x778154be start + 53624494
	5   DumpRenderTree                      0x77815730 start + 53625120
	6   DumpRenderTree                      0x77827cdb start + 53700299
	7   DumpRenderTree                      0x77827727 start + 53698839
	8   DumpRenderTree                      0x77814f1b start + 53623051
	9   DumpRenderTree                      0x77817a03 start + 53634035
	10  DumpRenderTree                      0x74ac496b start + 6107995
	11  DumpRenderTree                      0x74ac2002 start + 6097394
	12  DumpRenderTree                      0x74ac2251 start + 6097985
	13  DumpRenderTree                      0x74ac247d start + 6098541
	14  DumpRenderTree                      0x74ad4a5c start + 6173772
	15  DumpRenderTree                      0x74ac1893 start + 6095491
	16  DumpRenderTree                      0x74ac0cbb start + 6092459
	17  DumpRenderTree                      0x74ac0c00 start + 6092272
	18  DumpRenderTree                      0x74b595b2 start + 6717346
	19  DumpRenderTree                      0x74b59773 start + 6717795
	20  DumpRenderTree                      0x74b57a16 start + 6710278
	21  libSystem.B.dylib                   0x92c2f055 _pthread_start + 321
	22  libSystem.B.dylib                   0x92c2ef12 thread_start + 34


[46273:58883:89418794814428:FATAL:ffmpeg_video_decoder.cc(186)] Check failed: state_ != kStopped (7 vs. 7)
Backtrace:
	0   DumpRenderTree                      0x744b132f _mh_execute_header + 21295
	1   DumpRenderTree                      0x744b12cb _mh_execute_header + 21195
	2   DumpRenderTree                      0x744b2dbc _mh_execute_header + 28092
	3   DumpRenderTree                      0x744b230b _mh_execute_header + 25355
	4   DumpRenderTree                      0x77814e38 start + 53622824
	5   DumpRenderTree                      0x77817a03 start + 53634035
	6   DumpRenderTree                      0x74ac496b start + 6107995
	7   DumpRenderTree                      0x74ac2002 start + 6097394
	8   DumpRenderTree                      0x74ac2251 start + 6097985
	9   DumpRenderTree                      0x74ac247d start + 6098541
	10  DumpRenderTree                      0x74ad4a5c start + 6173772
	11  DumpRenderTree                      0x74ac1893 start + 6095491
	12  DumpRenderTree                      0x74ac0cbb start + 6092459
	13  DumpRenderTree                      0x74ac0c00 start + 6092272
	14  DumpRenderTree                      0x74b595b2 start + 6717346
	15  DumpRenderTree                      0x74b59773 start + 6717795
	16  DumpRenderTree                      0x74b57a16 start + 6710278
	17  libSystem.B.dylib                   0x92c2f055 _pthread_start + 321
	18  libSystem.B.dylib                   0x92c2ef12 thread_start + 34

/b/build/slave/webkit-mac-cg-latest-dbg/build/src/webkit/support/webkit_support.cc:79: Failure
Failed
[46273:58883:89418794814428:FATAL:ffmpeg_video_decoder.cc(186)] Check failed: state_ != kStopped (7 vs. 7)
Backtrace:
	0   DumpRenderTree                      0x744b132f _mh_execute_header + 21295
	1   DumpRenderTree                      0x744b12cb _mh_execute_header + 21195
	2   DumpRenderTree                      0x744b2dbc _mh_execute_header + 28092
	3   DumpRenderTree                      0x744b230b _mh_execute_header + 25355
	4   DumpRenderTree                      0x77814e38 start + 53622824
	5   DumpRenderTree                      0x77817a03 start + 53634035
	6   DumpRenderTree                      0x74ac496b start + 6107995
	7   DumpRenderTree                      0x74ac2002 start + 6097394
	8   DumpRenderTree                      0x74ac2251 start + 6097985
	9   DumpRenderTree                      0x74ac247d start + 6098541
	10  DumpRenderTree                      0x74ad4a5c start + 6173772
	11  DumpRenderTree                      0x74ac1893 start + 6095491
	12  DumpRenderTree                      0x74ac0cbb start + 6092459
	13  DumpRenderTree                      0x74ac0c00 start + 6092272
	14  DumpRenderTree                      0x74b595b2 start + 6717346
	15  DumpRenderTree                      0x74b59773 start + 6717795
	16  DumpRenderTree                      0x74b57a16 start + 6710278
	17  libSystem.B.dylib                   0x92c2f055 _pthread_start + 321
	18  libSystem.B.dylib                   0x92c2ef12 thread_start + 34


[46273:58883:89418795571747:FATAL:ffmpeg_video_decoder.cc(260)] Check failed: state_ != kStopped (7 vs. 7)
Backtrace:
	0   DumpRenderTree                      0x744b132f _mh_execute_header + 21295
	1   DumpRenderTree                      0x744b12cb _mh_execute_header + 21195
	2   DumpRenderTree                      0x744b2dbc _mh_execute_header + 28092
	3   DumpRenderTree                      0x744b230b _mh_execute_header + 25355
	4   DumpRenderTree                      0x778154be start + 53624494
	5   DumpRenderTree                      0x77815730 start + 53625120
	6   DumpRenderTree                      0x77827cdb start + 53700299
	7   DumpRenderTree                      0x77827727 start + 53698839
	8   DumpRenderTree                      0x77814f1b start + 53623051
	9   DumpRenderTree                      0x77817a03 start + 53634035
	10  DumpRenderTree                      0x74ac496b start + 6107995
	11  DumpRenderTree                      0x74ac2002 start + 6097394
	12  DumpRenderTree                      0x74ac2251 start + 6097985
	13  DumpRenderTree                      0x74ac247d start + 6098541
	14  DumpRenderTree                      0x74ad4a5c start + 6173772
	15  DumpRenderTree                      0x74ac1893 start + 6095491
	16  DumpRenderTree                      0x74ac0cbb start + 6092459
	17  DumpRenderTree                      0x74ac0c00 start + 6092272
	18  DumpRenderTree                      0x74b595b2 start + 6717346
	19  DumpRenderTree                      0x74b59773 start + 6717795
	20  DumpRenderTree                      0x74b57a16 start + 6710278
	21  libSystem.B.dylib                   0x92c2f055 _pthread_start + 321
	22  libSystem.B.dylib                   0x92c2ef12 thread_start + 34

/b/build/slave/webkit-mac-cg-latest-dbg/build/src/webkit/support/webkit_support.cc:79: Failure
Failed
[46273:58883:89418795571747:FATAL:ffmpeg_video_decoder.cc(260)] Check failed: state_ != kStopped (7 vs. 7)
Backtrace:
	0   DumpRenderTree                      0x744b132f _mh_execute_header + 21295
	1   DumpRenderTree                      0x744b12cb _mh_execute_header + 21195
	2   DumpRenderTree                      0x744b2dbc _mh_execute_header + 28092
	3   DumpRenderTree                      0x744b230b _mh_execute_header + 25355
	4   DumpRenderTree                      0x778154be start + 53624494
	5   DumpRenderTree                      0x77815730 start + 53625120
	6   DumpRenderTree                      0x77827cdb start + 53700299
	7   DumpRenderTree                      0x77827727 start + 53698839
	8   DumpRenderTree                      0x77814f1b start + 53623051
	9   DumpRenderTree                      0x77817a03 start + 53634035
	10  DumpRenderTree                      0x74ac496b start + 6107995
	11  DumpRenderTree                      0x74ac2002 start + 6097394
	12  DumpRenderTree                      0x74ac2251 start + 6097985
	13  DumpRenderTree                      0x74ac247d start + 6098541
	14  DumpRenderTree                      0x74ad4a5c start + 6173772
	15  DumpRenderTree                      0x74ac1893 start + 6095491
	16  DumpRenderTree                      0x74ac0cbb start + 6092459
	17  DumpRenderTree                      0x74ac0c00 start + 6092272
	18  DumpRenderTree                      0x74b595b2 start + 6717346
	19  DumpRenderTree                      0x74b59773 start + 6717795
	20  DumpRenderTree                      0x74b57a16 start + 6710278
	21  libSystem.B.dylib                   0x92c2f055 _pthread_start + 321
	22  libSystem.B.dylib                   0x92c2ef12 thread_start + 34


Test that right clicking on the timebar does not cause a seek.

RUN(video.autoplay = true)
EVENT(playing)
END OF TEST

The error above is for LEOPARD-CG DEBUG.

[Ami Fischman]

Created attachment 119693 [details]
Patch

[WebKit Review Bot]

Comment on attachment 119693 [details]
Patch

Clearing flags on attachment: 119693

Committed r103137: <http://trac.webkit.org/changeset/103137>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.