Bug 68743 - Canvas security checks show up on HTML5GamingTest benchmark
Summary: Canvas security checks show up on HTML5GamingTest benchmark
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-23 16:02 PDT by Adam Barth
Modified: 2011-09-24 09:38 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.81 KB, patch)
2011-09-23 16:05 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (3.73 KB, patch)
2011-09-23 17:23 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-09-23 16:02:21 PDT 
Canvas security checks show up on HTML5GamingTest benchmark
Comment 1 Adam Barth 2011-09-23 16:05:14 PDT 
Created attachment 108552 [details]
Patch
Comment 2 Alexey Proskuryakov 2011-09-23 16:51:08 PDT 
Comment on attachment 108552 [details]
Patch

Is this code main thread only? Another function in this file uses AtomicallyInitializedStatic, making me suspicious of DEFINE_STATIC_LOCAL use.
Comment 3 Adam Barth 2011-09-23 17:23:52 PDT 
Created attachment 108565 [details]
Patch
Comment 4 WebKit Review Bot 2011-09-23 20:51:04 PDT 
Comment on attachment 108565 [details]
Patch

Clearing flags on attachment: 108565

Committed r95900: <http://trac.webkit.org/changeset/95900>
Comment 5 WebKit Review Bot 2011-09-23 20:51:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Mark Rowe (bdash) 2011-09-23 22:04:53 PDT 
This broke all of the Mac builds because it introduced an exit-time destructor.  Please keep an eye on the build bots when landing changes in the future.
Comment 7 Adam Barth 2011-09-24 09:38:52 PDT 
(In reply to comment #6)
> This broke all of the Mac builds because it introduced an exit-time destructor.  Please keep an eye on the build bots when landing changes in the future.

Thanks for fixing the build for me.