RESOLVED FIXED Bug 68741
Add static version of JSCell::getCallData 
https://bugs.webkit.org/show_bug.cgi?id=68741
Summary Add static version of JSCell::getCallData
Mark Hahnenberg
Reported 2011-09-23 15:50:59 PDT
In the ongoing effort to un-virtualize JSCell, we need to replace getCallData with a non-virtual version. This will eventually be done by adding a function pointer to the ClassInfo struct. This patch will be similar to bug 68404.
Attachments
Patch (75.36 KB, patch)
2011-09-25 12:32 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (76.22 KB, patch)
2011-09-26 14:52 PDT, Mark Hahnenberg 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-09-25 12:32:11 PDT
Created attachment 108609 [details] Patch
Early Warning System Bot
Comment 2 2011-09-26 00:37:28 PDT
Comment on attachment 108609 [details] Patch Attachment 108609 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9842812
Darin Adler
Comment 3 2011-09-26 14:12:59 PDT
Comment on attachment 108609 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108609&action=review One thing that’s bad about the new functions is that they all have unchecked type casts in them. It makes me wish there was some way to check the types in all those cases are correct. Looks like this did not build on Qt. r=me if you address the Qt build failure > Source/JavaScriptCore/ChangeLog:13 > + able to more easily store and refer to them in our custom vtable since normal I’d say in our “method table” not our “custom viable”. > Source/JavaScriptCore/ChangeLog:15 > + impossible to store them generically in ClassInfo. I think I’d say something more like this: Function pointers are smaller and more efficient to call than pointers to member functions, and using static member functions allows us to use function pointers.
Mark Hahnenberg
Comment 4 2011-09-26 14:52:24 PDT
Created attachment 108727 [details] Patch
Darin Adler
Comment 5 2011-09-26 20:25:08 PDT
Comment on attachment 108727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108727&action=review > Source/JavaScriptGlue/ChangeLog:14 > + can be represented as function pointers rather than pointers to member methods, and > + function pointers are smaller and faster to call than pointers to member methods. The term is "member functions", not "member methods".
Mark Hahnenberg
Comment 6 2011-09-27 15:45:57 PDT
Committed r96164: <http://trac.webkit.org/changeset/96164>
Note You need to log in before you can comment on or make changes to this bug.