Bug 68731 - Outline sides are clipped in multicol and regions (regions fix landed)
Summary: Outline sides are clipped in multicol and regions (regions fix landed)
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-09-23 14:33 PDT by Alan Stearns
Modified: 2013-01-22 05:01 PST (History)
6 users (show)

See Also:

Attachments
Testcase for multicol (381 bytes, text/html)
2011-09-23 14:33 PDT, Alan Stearns 		no flags Details
Testcase for regions (388 bytes, text/html)
2011-09-23 14:33 PDT, Alan Stearns 		no flags Details
Patch (24.53 KB, patch)
2011-10-05 09:56 PDT, Dave Hyatt 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Stearns 2011-09-23 14:33:22 PDT 
Created attachment 108536 [details]
Testcase for multicol

If you have an element with an outline set that is displayed either in a region or a column, the sides of the outline do not display.
Comment 1 Alan Stearns 2011-09-23 14:33:44 PDT 
Created attachment 108537 [details]
Testcase for regions
Comment 2 Radar WebKit Bug Importer 2011-09-30 16:08:50 PDT 
<rdar://problem/10218167>
Comment 3 Dave Hyatt 2011-10-05 09:56:44 PDT 
Created attachment 109813 [details]
Patch
Comment 4 Dave Hyatt 2011-10-05 09:58:33 PDT 
Fixing this for multicol is really a separate bug. The attached patch fixes the issue for regions. I want to re-implement columns using regions anyway. :)
Comment 5 Darin Adler 2011-10-05 09:59:33 PDT 
Comment on attachment 109813 [details]
Patch

Does the test case cover all the changes?
Comment 6 Dave Hyatt 2011-10-05 10:01:10 PDT 
It does yes. Outline spilling out to the top/left gives you a negative overflow and tests the subsequent changes to translation and clipping.
Comment 7 Dave Hyatt 2011-10-05 10:04:50 PDT 
Regions fix landed in r96718. Cutting regions tracking bug dependency and leaving open for a multi-column fix.