Bug 68724 - ValueToDouble handling in prediction propagation should be ASSERT_NOT_REACHED
Summary: ValueToDouble handling in prediction propagation should be ASSERT_NOT_REACHED
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-23 13:30 PDT by Filip Pizlo
Modified: 2011-09-23 15:57 PDT (History)
4 users (show)

See Also:

Attachments
the patch (1.25 KB, patch)
2011-09-23 13:31 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-09-23 13:30:15 PDT 
ValueToDouble is inserted as a result of prediction propagation. It should never be inserted by the parser. Hence, it should be handled by the prediction propagator by asserting that the case is not reached.
Comment 1 Filip Pizlo 2011-09-23 13:31:41 PDT 
Created attachment 108525 [details]
the patch
Comment 2 WebKit Review Bot 2011-09-23 15:57:41 PDT 
Comment on attachment 108525 [details]
the patch

Clearing flags on attachment: 108525

Committed r95876: <http://trac.webkit.org/changeset/95876>
Comment 3 WebKit Review Bot 2011-09-23 15:57:45 PDT 
All reviewed patches have been landed.  Closing bug.