RESOLVED FIXED 68716
Add a bunch of unhandled node types to the propagator 
https://bugs.webkit.org/show_bug.cgi?id=68716
Summary Add a bunch of unhandled node types to the propagator
Oliver Hunt
Reported 2011-09-23 12:39:56 PDT
Add a bunch of unhandled node types to the propagator
Attachments
Patch (2.28 KB, patch)
2011-09-23 12:41 PDT, Oliver Hunt 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-09-23 12:41:50 PDT
Created attachment 108510 [details] Patch
Darin Adler
Comment 2 2011-09-23 12:43:28 PDT
Comment on attachment 108510 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108510&action=review > Source/JavaScriptCore/dfg/DFGPropagator.cpp:-610 > - ASSERT_NOT_REACHED(); Might still be nice to have an ASSERT_NOT_REACHED when the node type is not a legal enum value. Sometimes we do that by using return instead of break, and then asserting outside the switch statement.
Gavin Barraclough
Comment 3 2011-09-23 12:46:09 PDT
Comment on attachment 108510 [details] Patch r+ with or without ValueToDouble doing anything.
Oliver Hunt
Comment 4 2011-09-23 12:47:38 PDT
Committed r95851: <http://trac.webkit.org/changeset/95851>
Filip Pizlo
Comment 5 2011-09-23 12:50:37 PDT
Comment on attachment 108510 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108510&action=review > Source/JavaScriptCore/dfg/DFGPropagator.cpp:404 > + changed |= mergePrediction(makePrediction(PredictNumber, StrongPrediction)); This should be PredictDouble. PredictNumber means that it could be either double or int32. ValueToDouble only returns doubles. But also, this is dead code: ValueToDouble should never come up at this stage of compilation, since it is only introduced during post-propagation fixup just following this fixpoint. We could put ASSERT_NOT_REACHED here.
Note You need to log in before you can comment on or make changes to this bug.