Bug 68704 - Implement op_resolve_global in the DFG JIT
Summary: Implement op_resolve_global in the DFG JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-23 10:38 PDT by Gavin Barraclough
Modified: 2011-09-23 11:52 PDT (History)
0 users

See Also:


Attachments
Fix (8.86 KB, patch)
2011-09-23 10:39 PDT, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-09-23 10:38:16 PDT
This is performance neutral, but increases coverage.
Comment 1 Gavin Barraclough 2011-09-23 10:39:51 PDT
Created attachment 108490 [details]
Fix
Comment 2 Oliver Hunt 2011-09-23 10:52:42 PDT
Comment on attachment 108490 [details]
Fix

r=me
Comment 3 Mark Rowe (bdash) 2011-09-23 10:57:12 PDT
Comment on attachment 108490 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=108490&action=review

> Source/JavaScriptCore/ChangeLog:37
> +2011-09-22  Gavin Barraclough  <barraclough@apple.com>
> +
> +        Need a short description and bug URL (OOPS!)
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * dfg/DFGByteCodeParser.cpp:
> +        (JSC::DFG::ByteCodeParser::ByteCodeParser):
> +        (JSC::DFG::ByteCodeParser::parseBlock):
> +        * dfg/DFGNode.h:
> +        (JSC::DFG::Node::hasIdentifier):
> +        (JSC::DFG::Node::resolveInfoIndex):
> +        * dfg/DFGOperations.cpp:
> +        * dfg/DFGOperations.h:
> +        * dfg/DFGSpeculativeJIT.cpp:
> +        (JSC::DFG::SpeculativeJIT::compile):
> +

I don’t think you want to include this bit.
Comment 4 Gavin Barraclough 2011-09-23 11:52:14 PDT
Opps! - yep.
Fixed in r95840.