Bug 68699 - [EFL] Add virtual method to notify user when wrapping focus
Summary: [EFL] Add virtual method to notify user when wrapping focus
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas De Marchi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-23 08:21 PDT by Lucas De Marchi
Modified: 2011-09-26 12:57 PDT (History)
5 users (show)

See Also:


Attachments
Patch (5.98 KB, patch)
2011-09-23 09:49 PDT, Lucas De Marchi
no flags Details | Formatted Diff | Diff
Patch (5.91 KB, patch)
2011-09-26 12:16 PDT, Lucas De Marchi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas De Marchi 2011-09-23 08:21:20 PDT
[EFL] Add virtual method to notify user when wrapping focus
Comment 1 Lucas De Marchi 2011-09-23 09:49:14 PDT
Created attachment 108484 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-09-23 09:53:16 PDT
Informal r+.
Comment 3 Lucas De Marchi 2011-09-23 13:24:50 PDT
CC'ing reviewers.
Comment 4 Antonio Gomes 2011-09-23 14:01:40 PDT
Comment on attachment 108484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review

Does it need API review?

> Source/WebKit/efl/ewk/ewk_view.h:117
> +    EWK_FOCUS_DIRECTION_BACKWARD,
> +    EWK_FOCUS_DIRECTION_UP,
> +    EWK_FOCUS_DIRECTION_DOWN,
> +    EWK_FOCUS_DIRECTION_LEFT,
> +    EWK_FOCUS_DIRECTION_RIGHT,

Is it for TAB navigation. Do you need the arrow ones?
Comment 5 Lucas De Marchi 2011-09-23 15:22:09 PDT
(In reply to comment #4)
> (From update of attachment 108484 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review
> 
> Does it need API review?
> 
> > Source/WebKit/efl/ewk/ewk_view.h:117
> > +    EWK_FOCUS_DIRECTION_BACKWARD,
> > +    EWK_FOCUS_DIRECTION_UP,
> > +    EWK_FOCUS_DIRECTION_DOWN,
> > +    EWK_FOCUS_DIRECTION_LEFT,
> > +    EWK_FOCUS_DIRECTION_RIGHT,
> 
> Is it for TAB navigation. Do you need the arrow ones?

I thought we could actually wrap when going through a certain direction, but FocusController::advanceFocusDirectionally() doesn't call this function. Is it on purpose or just a missing functionality?
Comment 6 Antonio Gomes 2011-09-23 17:41:15 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 108484 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review
> > 
> > Does it need API review?
> > 
> > > Source/WebKit/efl/ewk/ewk_view.h:117
> > > +    EWK_FOCUS_DIRECTION_BACKWARD,
> > > +    EWK_FOCUS_DIRECTION_UP,
> > > +    EWK_FOCUS_DIRECTION_DOWN,
> > > +    EWK_FOCUS_DIRECTION_LEFT,
> > > +    EWK_FOCUS_DIRECTION_RIGHT,
> > 
> > Is it for TAB navigation. Do you need the arrow ones?
> 
> I thought we could actually wrap when going through a certain direction, but FocusController::advanceFocusDirectionally() doesn't call this function. Is it on purpose or just a missing functionality?

wrapping in direction navigation would not really make users happy :).
Comment 7 Lucas De Marchi 2011-09-26 12:16:20 PDT
Created attachment 108706 [details]
Patch
Comment 8 Lucas De Marchi 2011-09-26 12:19:03 PDT
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > (From update of attachment 108484 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review
> > > 
> > > Does it need API review?
> > > 
> > > > Source/WebKit/efl/ewk/ewk_view.h:117
> > > > +    EWK_FOCUS_DIRECTION_BACKWARD,
> > > > +    EWK_FOCUS_DIRECTION_UP,
> > > > +    EWK_FOCUS_DIRECTION_DOWN,
> > > > +    EWK_FOCUS_DIRECTION_LEFT,
> > > > +    EWK_FOCUS_DIRECTION_RIGHT,
> > > 
> > > Is it for TAB navigation. Do you need the arrow ones?
> > 
> > I thought we could actually wrap when going through a certain direction, but FocusController::advanceFocusDirectionally() doesn't call this function. Is it on purpose or just a missing functionality?
> 
> wrapping in direction navigation would not really make users happy :).

Ok, I uploaded a new patch then.
Comment 9 Lucas De Marchi 2011-09-26 12:57:34 PDT
Comment on attachment 108706 [details]
Patch

Clearing flags on attachment: 108706

Committed r95983: <http://trac.webkit.org/changeset/95983>
Comment 10 Lucas De Marchi 2011-09-26 12:57:42 PDT
All reviewed patches have been landed.  Closing bug.