Bug 68699 – [EFL] Add virtual method to notify user when wrapping focus

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Lucas De Marchi]

[EFL] Add virtual method to notify user when wrapping focus

[Lucas De Marchi]

Created attachment 108484 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Informal r+.

[Lucas De Marchi]

CC'ing reviewers.

[Antonio Gomes]

Comment on attachment 108484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review

Does it need API review?

> Source/WebKit/efl/ewk/ewk_view.h:117
> +    EWK_FOCUS_DIRECTION_BACKWARD,
> +    EWK_FOCUS_DIRECTION_UP,
> +    EWK_FOCUS_DIRECTION_DOWN,
> +    EWK_FOCUS_DIRECTION_LEFT,
> +    EWK_FOCUS_DIRECTION_RIGHT,

Is it for TAB navigation. Do you need the arrow ones?

[Lucas De Marchi]

(In reply to comment #4)
> (From update of attachment 108484 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review
> 
> Does it need API review?
> 
> > Source/WebKit/efl/ewk/ewk_view.h:117
> > +    EWK_FOCUS_DIRECTION_BACKWARD,
> > +    EWK_FOCUS_DIRECTION_UP,
> > +    EWK_FOCUS_DIRECTION_DOWN,
> > +    EWK_FOCUS_DIRECTION_LEFT,
> > +    EWK_FOCUS_DIRECTION_RIGHT,
> 
> Is it for TAB navigation. Do you need the arrow ones?

I thought we could actually wrap when going through a certain direction, but FocusController::advanceFocusDirectionally() doesn't call this function. Is it on purpose or just a missing functionality?

[Antonio Gomes]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 108484 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review
> > 
> > Does it need API review?
> > 
> > > Source/WebKit/efl/ewk/ewk_view.h:117
> > > +    EWK_FOCUS_DIRECTION_BACKWARD,
> > > +    EWK_FOCUS_DIRECTION_UP,
> > > +    EWK_FOCUS_DIRECTION_DOWN,
> > > +    EWK_FOCUS_DIRECTION_LEFT,
> > > +    EWK_FOCUS_DIRECTION_RIGHT,
> > 
> > Is it for TAB navigation. Do you need the arrow ones?
> 
> I thought we could actually wrap when going through a certain direction, but FocusController::advanceFocusDirectionally() doesn't call this function. Is it on purpose or just a missing functionality?

wrapping in direction navigation would not really make users happy :).

[Lucas De Marchi]

Created attachment 108706 [details]
Patch

[Lucas De Marchi]

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > (From update of attachment 108484 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=108484&action=review
> > > 
> > > Does it need API review?
> > > 
> > > > Source/WebKit/efl/ewk/ewk_view.h:117
> > > > +    EWK_FOCUS_DIRECTION_BACKWARD,
> > > > +    EWK_FOCUS_DIRECTION_UP,
> > > > +    EWK_FOCUS_DIRECTION_DOWN,
> > > > +    EWK_FOCUS_DIRECTION_LEFT,
> > > > +    EWK_FOCUS_DIRECTION_RIGHT,
> > > 
> > > Is it for TAB navigation. Do you need the arrow ones?
> > 
> > I thought we could actually wrap when going through a certain direction, but FocusController::advanceFocusDirectionally() doesn't call this function. Is it on purpose or just a missing functionality?
> 
> wrapping in direction navigation would not really make users happy :).

Ok, I uploaded a new patch then.

[Lucas De Marchi]

Comment on attachment 108706 [details]
Patch

Clearing flags on attachment: 108706

Committed r95983: <http://trac.webkit.org/changeset/95983>

[Lucas De Marchi]

All reviewed patches have been landed.  Closing bug.