Bug 68698 - update layout_tests to account for new default of use_skia=1
Summary: update layout_tests to account for new default of use_skia=1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh Unspecified
: P2 Normal
Assignee: epoger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-23 08:14 PDT by epoger
Modified: 2011-09-23 12:45 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.40 KB, patch)
2011-09-23 08:17 PDT, epoger
no flags Details | Formatted Diff | Diff
Patch (7.67 KB, patch)
2011-09-23 11:25 PDT, epoger
no flags Details | Formatted Diff | Diff
Patch (8.11 KB, patch)
2011-09-23 12:08 PDT, epoger
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description epoger 2011-09-23 08:14:20 PDT
Once the Chromium CL in http://codereview.chromium.org/8002009 is committed, Chromium will default to using the Skia graphics library on Mac (instead of Core Graphics).

This change needs to be reflected in the layout_test machinery: the default port for mac changes from chromium-cg-mac to chromium-mac.

This CL will cause some layout_tests to fail unless the aforementioned Chromium CL has been picked up as well.
Comment 1 epoger 2011-09-23 08:17:17 PDT
Created attachment 108477 [details]
Patch
Comment 2 Mihai Parparita 2011-09-23 09:17:30 PDT
(In reply to comment #0)
> This CL will cause some layout_tests to fail unless the aforementioned Chromium CL has been picked up as well.

Does this mean that you'll need to land the Chromium change first, and update this patch to also modify http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS to set chromium_rev to that revision?
Comment 3 epoger 2011-09-23 10:17:08 PDT
(In reply to comment #2)
> (In reply to comment #0)
> > This CL will cause some layout_tests to fail unless the aforementioned Chromium CL has been picked up as well.
> 
> Does this mean that you'll need to land the Chromium change first, and update this patch to also modify http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS to set chromium_rev to that revision?

Yes, you're right, I will have to do that.
Comment 4 epoger 2011-09-23 11:25:50 PDT
Created attachment 108498 [details]
Patch
Comment 5 epoger 2011-09-23 12:08:33 PDT
Created attachment 108505 [details]
Patch
Comment 6 Mihai Parparita 2011-09-23 12:45:50 PDT
Comment on attachment 108505 [details]
Patch

Clearing flags on attachment: 108505

Committed r95850: <http://trac.webkit.org/changeset/95850>
Comment 7 Mihai Parparita 2011-09-23 12:45:54 PDT
All reviewed patches have been landed.  Closing bug.