RESOLVED FIXED 68698
update layout_tests to account for new default of use_skia=1 
https://bugs.webkit.org/show_bug.cgi?id=68698
Summary update layout_tests to account for new default of use_skia=1
epoger
Reported 2011-09-23 08:14:20 PDT
Once the Chromium CL in http://codereview.chromium.org/8002009 is committed, Chromium will default to using the Skia graphics library on Mac (instead of Core Graphics). This change needs to be reflected in the layout_test machinery: the default port for mac changes from chromium-cg-mac to chromium-mac. This CL will cause some layout_tests to fail unless the aforementioned Chromium CL has been picked up as well.
Attachments
Patch (6.40 KB, patch)
2011-09-23 08:17 PDT, epoger 		no flags
DetailsFormatted DiffDiff
Patch (7.67 KB, patch)
2011-09-23 11:25 PDT, epoger 		no flags
DetailsFormatted DiffDiff
Patch (8.11 KB, patch)
2011-09-23 12:08 PDT, epoger 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
epoger
Comment 1 2011-09-23 08:17:17 PDT
Created attachment 108477 [details] Patch
Mihai Parparita
Comment 2 2011-09-23 09:17:30 PDT
(In reply to comment #0) > This CL will cause some layout_tests to fail unless the aforementioned Chromium CL has been picked up as well. Does this mean that you'll need to land the Chromium change first, and update this patch to also modify http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS to set chromium_rev to that revision?
epoger
Comment 3 2011-09-23 10:17:08 PDT
(In reply to comment #2) > (In reply to comment #0) > > This CL will cause some layout_tests to fail unless the aforementioned Chromium CL has been picked up as well. > > Does this mean that you'll need to land the Chromium change first, and update this patch to also modify http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS to set chromium_rev to that revision? Yes, you're right, I will have to do that.
epoger
Comment 4 2011-09-23 11:25:50 PDT
Created attachment 108498 [details] Patch
epoger
Comment 5 2011-09-23 12:08:33 PDT
Created attachment 108505 [details] Patch
Mihai Parparita
Comment 6 2011-09-23 12:45:50 PDT
Comment on attachment 108505 [details] Patch Clearing flags on attachment: 108505 Committed r95850: <http://trac.webkit.org/changeset/95850>
Mihai Parparita
Comment 7 2011-09-23 12:45:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.