RESOLVED FIXED 68695
Web Inspector: Timeline: record root event for the function calls enforced by console eval. 
https://bugs.webkit.org/show_bug.cgi?id=68695
Summary Web Inspector: Timeline: record root event for the function calls enforced by...
Ilya Tikhonovsky
Reported 2011-09-23 07:00:36 PDT
In a complex web application developer might want to timeline a specific piece of code. In this case he can do the next steps: 1) start timeline; 2) eval a command in console; 3) stop timeline. I think it'd be nice to have a root event for the all the events that happened as the result of such eval.
Attachments
Patch (8.41 KB, patch)
2011-09-23 09:22 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (8.04 KB, patch)
2011-09-26 01:19 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2011-09-23 09:22:00 PDT
Created attachment 108483 [details] Patch
WebKit Review Bot
Comment 2 2011-09-23 13:58:02 PDT
Comment on attachment 108483 [details] Patch Attachment 108483 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9801680
Yury Semikhatsky
Comment 3 2011-09-26 00:58:35 PDT
Comment on attachment 108483 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108483&action=review > Source/WebCore/bindings/v8/ScriptFunctionCall.cpp:34 > +#include "DOMWindow.h" Why do you need this? > Source/WebCore/inspector/InjectedScript.cpp:194 > + DOMWindow* domWindow = domWindowFromScriptState(m_injectedScriptObject.scriptState()); domWindow may be 0, e.g. in case of worker context, r- for this.
Ilya Tikhonovsky
Comment 4 2011-09-26 01:19:32 PDT
Created attachment 108644 [details] Patch
Ilya Tikhonovsky
Comment 5 2011-09-26 05:11:43 PDT
Committed r95941: <http://trac.webkit.org/changeset/95941>
Note You need to log in before you can comment on or make changes to this bug.