Bug 68695 - Web Inspector: Timeline: record root event for the function calls enforced by console eval.
Summary: Web Inspector: Timeline: record root event for the function calls enforced by...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
Depends on:
Reported: 2011-09-23 07:00 PDT by Ilya Tikhonovsky
Modified: 2011-09-26 05:11 PDT (History)
10 users (show)

See Also:

Patch (8.41 KB, patch)
2011-09-23 09:22 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (8.04 KB, patch)
2011-09-26 01:19 PDT, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2011-09-23 07:00:36 PDT
In a complex web application developer might want to timeline a specific piece of code.

In this case he can do the next steps:
1) start timeline;
2) eval a command in console;
3) stop timeline.

I think it'd be nice to have a root event for the all the events that happened as the result of such eval.
Comment 1 Ilya Tikhonovsky 2011-09-23 09:22:00 PDT
Created attachment 108483 [details]
Comment 2 WebKit Review Bot 2011-09-23 13:58:02 PDT
Comment on attachment 108483 [details]

Attachment 108483 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9801680
Comment 3 Yury Semikhatsky 2011-09-26 00:58:35 PDT
Comment on attachment 108483 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=108483&action=review

> Source/WebCore/bindings/v8/ScriptFunctionCall.cpp:34
> +#include "DOMWindow.h"

Why do you need this?

> Source/WebCore/inspector/InjectedScript.cpp:194
> +    DOMWindow* domWindow = domWindowFromScriptState(m_injectedScriptObject.scriptState());

domWindow may be 0, e.g. in case of worker context, r- for this.
Comment 4 Ilya Tikhonovsky 2011-09-26 01:19:32 PDT
Created attachment 108644 [details]
Comment 5 Ilya Tikhonovsky 2011-09-26 05:11:43 PDT
Committed r95941: <http://trac.webkit.org/changeset/95941>