Bug 68673 - enable NRWT for run-webkit-tests on Lion
Summary: enable NRWT for run-webkit-tests on Lion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-22 18:09 PDT by Dirk Pranke
Modified: 2011-09-23 17:08 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.22 KB, patch)
2011-09-22 18:09 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-09-22 18:09:13 PDT 
enable NRWT for run-webkit-tests on Lion
Comment 1 Dirk Pranke 2011-09-22 18:09:55 PDT 
Created attachment 108435 [details]
Patch
Comment 2 Dirk Pranke 2011-09-22 18:14:58 PDT 
I don't actually have a Lion box handy to test this and make sure it works; it seems like we should probably test this somewhere before we just land this and the bot picks it up automatically (IIRC how the bot is configured) ...
Comment 3 Eric Seidel (no email) 2011-09-22 18:17:56 PDT 
Comment on attachment 108435 [details]
Patch

LGTM.
Comment 4 Eric Seidel (no email) 2011-09-22 18:18:26 PDT 
I just don't have a lion box yet, that's why this hasn't been flipped.  But assuming new-run-webkit-tests works fine stand-alone on lion, this should work just fine.
Comment 5 WebKit Review Bot 2011-09-22 20:59:25 PDT 
Comment on attachment 108435 [details]
Patch

Clearing flags on attachment: 108435

Committed r95781: <http://trac.webkit.org/changeset/95781>
Comment 6 WebKit Review Bot 2011-09-22 20:59:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Darin Adler 2011-09-23 10:08:48 PDT 
I think this should be changed to a “deny” list instead of an “allow” list for OS X versions. When we are working on future versions post-Lion it is no good to fall back to the old run-webkit-tests!
Comment 8 Dirk Pranke 2011-09-23 10:51:25 PDT 
(In reply to comment #7)
> I think this should be changed to a “deny” list instead of an “allow” list for OS X versions. When we are working on future versions post-Lion it is no good to fall back to the old run-webkit-tests!

Makes sense. We should probably change this to a deny list, period.
Comment 9 Eric Seidel (no email) 2011-09-23 17:08:45 PDT 
I strongly support using a blacklist instead of a whitelist.

However, you should note I tried that and failed once:
http://trac.webkit.org/changeset/90440/trunk/Tools/Scripts/run-webkit-tests

Had to roll out the blacklist due to webkitdir.pm's behavior of removing arguments (or not removing arguments) based on if isGtk/isPort() whatever being called:
http://trac.webkit.org/changeset/90449/trunk/Tools/Scripts/run-webkit-tests