RESOLVED FIXED 68673
enable NRWT for run-webkit-tests on Lion 
https://bugs.webkit.org/show_bug.cgi?id=68673
Summary enable NRWT for run-webkit-tests on Lion
Dirk Pranke
Reported 2011-09-22 18:09:13 PDT
enable NRWT for run-webkit-tests on Lion
Attachments
Patch (1.22 KB, patch)
2011-09-22 18:09 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-09-22 18:09:55 PDT
Created attachment 108435 [details] Patch
Dirk Pranke
Comment 2 2011-09-22 18:14:58 PDT
I don't actually have a Lion box handy to test this and make sure it works; it seems like we should probably test this somewhere before we just land this and the bot picks it up automatically (IIRC how the bot is configured) ...
Eric Seidel (no email)
Comment 3 2011-09-22 18:17:56 PDT
Comment on attachment 108435 [details] Patch LGTM.
Eric Seidel (no email)
Comment 4 2011-09-22 18:18:26 PDT
I just don't have a lion box yet, that's why this hasn't been flipped. But assuming new-run-webkit-tests works fine stand-alone on lion, this should work just fine.
WebKit Review Bot
Comment 5 2011-09-22 20:59:25 PDT
Comment on attachment 108435 [details] Patch Clearing flags on attachment: 108435 Committed r95781: <http://trac.webkit.org/changeset/95781>
WebKit Review Bot
Comment 6 2011-09-22 20:59:29 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 7 2011-09-23 10:08:48 PDT
I think this should be changed to a “deny” list instead of an “allow” list for OS X versions. When we are working on future versions post-Lion it is no good to fall back to the old run-webkit-tests!
Dirk Pranke
Comment 8 2011-09-23 10:51:25 PDT
(In reply to comment #7) > I think this should be changed to a “deny” list instead of an “allow” list for OS X versions. When we are working on future versions post-Lion it is no good to fall back to the old run-webkit-tests! Makes sense. We should probably change this to a deny list, period.
Eric Seidel (no email)
Comment 9 2011-09-23 17:08:45 PDT
I strongly support using a blacklist instead of a whitelist. However, you should note I tried that and failed once: http://trac.webkit.org/changeset/90440/trunk/Tools/Scripts/run-webkit-tests Had to roll out the blacklist due to webkitdir.pm's behavior of removing arguments (or not removing arguments) based on if isGtk/isPort() whatever being called: http://trac.webkit.org/changeset/90449/trunk/Tools/Scripts/run-webkit-tests
Note You need to log in before you can comment on or make changes to this bug.