Bug 68669 – Remove unneeded type conversion from background bleed code

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Darin Adler]

Remove unneeded type conversion from background bleed code

[Darin Adler]

Created attachment 108429 [details]
Patch

[Geoffrey Garen]

Comment on attachment 108429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108429&action=review

r=me

> Source/WebCore/rendering/RenderBoxModelObject.cpp:593
> +    adjustedRect.inflateX(-ceil(1 / transform.xScale()));
> +    adjustedRect.inflateY(-ceil(1 / transform.yScale()));

Maybe 1.0 would be clearer here.

[Darin Adler]

Comment on attachment 108429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108429&action=review

>> Source/WebCore/rendering/RenderBoxModelObject.cpp:593
>> +    adjustedRect.inflateY(-ceil(1 / transform.yScale()));
> 
> Maybe 1.0 would be clearer here.

I like the 1 fine. Using 1.0 would subtly impose a conversion to double if the other type happened to be float. I prefer to just leave it off.

[WebKit Review Bot]

Comment on attachment 108429 [details]
Patch

Clearing flags on attachment: 108429

Committed r95778: <http://trac.webkit.org/changeset/95778>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Roben (:aroben)]

Looks like this broke 32-bit builds, with warnings like the following:


WebCore/rendering/RenderBoxModelObject.cpp: In function 'WebCore::LayoutRect WebCore::backgroundRectAdjustedForBleedAvoidance(WebCore::GraphicsContext*, const WebCore::LayoutRect&, WebCore::BackgroundBleedAvoidance)':
WebCore/rendering/RenderBoxModelObject.cpp:592: warning: implicit conversion shortens 64-bit value into a 32-bit value
WebCore/rendering/RenderBoxModelObject.cpp:593: warning: implicit conversion shortens 64-bit value into a 32-bit value

[Darin Adler]

(In reply to comment #6)
> Looks like this broke 32-bit builds, with warnings like the following:
> 
> 
> WebCore/rendering/RenderBoxModelObject.cpp: In function 'WebCore::LayoutRect WebCore::backgroundRectAdjustedForBleedAvoidance(WebCore::GraphicsContext*, const WebCore::LayoutRect&, WebCore::BackgroundBleedAvoidance)':
> WebCore/rendering/RenderBoxModelObject.cpp:592: warning: implicit conversion shortens 64-bit value into a 32-bit value
> WebCore/rendering/RenderBoxModelObject.cpp:593: warning: implicit conversion shortens 64-bit value into a 32-bit value

I’ll fix that right now.

[Darin Adler]

I’ll fix this by adding a cast. But that warning seems pointless. And this has nothing to do with 32 vs. 64-bit builds. The type float is always 32 and the type double is always 64. I think it might even be a compiler bug.

[Darin Adler]

(In reply to comment #6)
> Looks like this broke 32-bit builds

Thanks for the heads up, and thanks for not just rolling it out!