Bug 68667 - Use AffineTransform scale functions in ShadowBlur::adjustBlurRadius
Summary: Use AffineTransform scale functions in ShadowBlur::adjustBlurRadius
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 68722
  Show dependency treegraph
 
Reported: 2011-09-22 17:23 PDT by Darin Adler
Modified: 2011-09-23 13:17 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.47 KB, patch)
2011-09-22 17:24 PDT, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2011-09-22 17:23:31 PDT
Use AffineTransform scale functions in ShadowBlur::adjustBlurRadius
Comment 1 Darin Adler 2011-09-22 17:24:51 PDT
Created attachment 108425 [details]
Patch
Comment 2 Darin Adler 2011-09-22 17:25:36 PDT
Simon, please let me know if you think the new code will not do the same thing as the existing code.
Comment 3 Simon Fraser (smfr) 2011-09-22 17:29:23 PDT
Comment on attachment 108425 [details]
Patch

Looks right to me.
Comment 4 WebKit Review Bot 2011-09-22 21:09:30 PDT
Comment on attachment 108425 [details]
Patch

Clearing flags on attachment: 108425

Committed r95782: <http://trac.webkit.org/changeset/95782>
Comment 5 WebKit Review Bot 2011-09-22 21:09:34 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Julien Chaffraix 2011-09-23 13:01:24 PDT
Comment on attachment 108425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108425&action=review

> Source/WebCore/platform/graphics/ShadowBlur.cpp:359
> +    m_blurRadius.scale(1 / transform.xScale(), 1 / transform.yScale());

This line is failing on the Intel Debug bot. Here is the message:

ShadowBlur.cpp:359: warning: implicit conversion shortens 64-bit value into a 32-bit value
ShadowBlur.cpp:359: warning: implicit conversion shortens 64-bit value into a 32-bit value

xScale() and yScale() return a double that gets rounded to a float in FloatSize::scale(). Should I file a follow-up bug to fix the bot?
Comment 7 Simon Fraser (smfr) 2011-09-23 13:04:29 PDT
Yes please (or just post a patch here).