refactor RenderFlexibleBox to use flex-flow aware methods
Created attachment 108423 [details] Patch
Comment on attachment 108423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108423&action=review > Source/WebCore/rendering/RenderBlock.h:-213 > - // FIXME: Supporting layout deltas. > - void setLogicalLocationForChild(RenderBox* child, const LayoutPoint&); Can you add a line in the ChangeLog explaining why this is being removed (e.g., unused). > Source/WebCore/rendering/RenderFlexibleBox.cpp:116 > +LayoutUnit RenderFlexibleBox::hasOrthogonalFlow(RenderBox* child) const Shouldn't this return a bool? > Source/WebCore/rendering/RenderFlexibleBox.cpp:124 > +LayoutUnit RenderFlexibleBox::isHorizontalFlow() const Shouldn't this return a bool? > Source/WebCore/rendering/RenderFlexibleBox.cpp:130 > +LayoutUnit RenderFlexibleBox::isLeftToRightFlow() const Shouldn't this return a bool? > Source/WebCore/rendering/RenderFlexibleBox.cpp:415 > + // FIXME: I think we only want to do this for horizontal flows. For vertical flows, we'll need something like this to compute the physical width.
Created attachment 108523 [details] Patch
Committed r95856: <http://trac.webkit.org/changeset/95856>