Bug 68664 – <feImage> referencing an <image> via xlink:href doesn't display correctly

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Tim Horton]

Created attachment 108422 [details]
repro

Open the attached SVG in a WebKit browser and Opera.

Note how the <feImage> that references an <image> doesn't render, while the <feImage> which directly references an image does.

This breaks some of the "SVG Wow!" filters demos.

[Radar WebKit Bug Importer]

<rdar://problem/10172530>

[Tim Horton]

(In reply to comment #0)
> Note how the <feImage> that references an <image> doesn't render, while the <feImage> which directly references an image does.

"directly references an image does" means an image *file*, I left that quite ambiguous.

[Dirk Schulze]

Could be a problem of <image> which does not correctly rerender and does not invalidate the filter. I expect that the image was loaded after creating the filter.

[Tim Horton]

Actually, it looks like the computation of targetRect in SVGFEImageElement::build is wrong. Attaching another SVG which causes an assertion failure related to this (I removed the width/height on the <image>, so SVGFEImageElement::build is trying to create a 0x0 image for whatever reason, and failing and dying).

[Tim Horton]

Created attachment 108555 [details]
assert repro

[Tim Horton]

But that's a separate problem. As it stands, the first time we get to SVGFEImageElement::build, and go to paint the SVGImageElement, hasImage() is false so it doesn't paint, and from then on we never get anything indicating that we should invalidate.

[Tim Horton]

It almost seems like the notifyFinished calls make it everywhere *backwards*. More debugging!

[Tim Horton]

The more I look at this, the more lost I get. It looks like there are two RenderSVGImages for some reason (I've deleted everything not involved in #twolevel in the original repro), and the second one is not getting a valid image (but really, I'm not sure why it exists at all).

[Nikolas Zimmermann]

(In reply to comment #8)
> The more I look at this, the more lost I get. It looks like there are two RenderSVGImages for some reason (I've deleted everything not involved in #twolevel in the original repro), and the second one is not getting a valid image (but really, I'm not sure why it exists at all).

Can you attach the smaller repro?

[Tim Horton]

Created attachment 108760 [details]
smaller repro

surely!

[Tim Horton]

This works as of http://trac.webkit.org/changeset/101542, as long as you set the <image> dimensions correctly (width="320" height="320" instead of width="1" height="1").