Bug 68652 - Add ENABLE(CSS_FILTERS)
Summary: Add ENABLE(CSS_FILTERS)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks: 68469
  Show dependency tree / graph
 
Reported: 2011-09-22 13:23 PDT by Dean Jackson
Modified: 2011-10-03 06:37 PDT (History)
4 users (show)

See Also:

Attachments
Patch (23.13 KB, patch)
2011-09-22 16:21 PDT, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2011-09-22 13:23:53 PDT 
Add a define for the new filters work.
Comment 1 Radar WebKit Bug Importer 2011-09-22 13:24:44 PDT 
<rdar://problem/10170378>
Comment 2 Dean Jackson 2011-09-22 16:21:00 PDT 
Created attachment 108417 [details]
Patch
Comment 3 Dean Jackson 2011-09-22 17:38:06 PDT 
http://trac.webkit.org/changeset/95766
Comment 4 Balazs Kelemen 2011-09-23 02:53:05 PDT 
Don't you think it would be better to handle it via Platform.h? This is where such features are handled normally because it is a cleaner way than add logic to  every build system. --css-filter need to be handled with an extra define in this case but I think build-webkit is able to set such defines (every platform knows how to transform the set of features to -Dxxx compile switches). I can create the patch if you agree on me.
Comment 5 Dean Jackson 2011-09-23 12:59:34 PDT 
(In reply to comment #4)
> Don't you think it would be better to handle it via Platform.h? This is where such features are handled normally because it is a cleaner way than add logic to  every build system. --css-filter need to be handled with an extra define in this case but I think build-webkit is able to set such defines (every platform knows how to transform the set of features to -Dxxx compile switches). I can create the patch if you agree on me.

Can you explain why some features are in Platform.h and others are elsewhere? Platform seems to be for application-level stuff. I couldn't find anything in there that was similar to this feature. All the similar ones are done outside Platform (e.g. the existing ENABLE_FILTER)
Comment 6 Balazs Kelemen 2011-10-03 06:37:49 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > Don't you think it would be better to handle it via Platform.h? This is where such features are handled normally because it is a cleaner way than add logic to  every build system. --css-filter need to be handled with an extra define in this case but I think build-webkit is able to set such defines (every platform knows how to transform the set of features to -Dxxx compile switches). I can create the patch if you agree on me.
> 
> Can you explain why some features are in Platform.h and others are elsewhere? Platform seems to be for application-level stuff. I couldn't find anything in there that was similar to this feature. All the similar ones are done outside Platform (e.g. the existing ENABLE_FILTER)

Sorry for letting the topic rot - I was on holiday last week.
I have just written a mail to webkit-dev about this.