In the ongoing process of de-virtualizing JSCell, we now come to JSCell::getJSNumber.
Created attachment 108405 [details]
Comment on attachment 108405 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=108405&action=review
Please make NumberObject-ness a type instead of a flag.
> + static const unsigned IsNumberObject = 1 << 9;
I think this would be better as a JSType rather than a Structure flag. Flags are states that many kinds of objects might have; types identify a specific kind of object. Nothing other than NumberObject wants to set the IsNumberObject flag.
Created attachment 108418 [details]
Created attachment 108419 [details]
Created attachment 108430 [details]
Comment on attachment 108430 [details]
Created attachment 108514 [details]
Created attachment 108516 [details]
Comment on attachment 108516 [details]
Committed r95893: <http://trac.webkit.org/changeset/95893>