Bug 68651 - De-virtualize JSCell::getJSNumber
Summary: De-virtualize JSCell::getJSNumber
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 67690
  Show dependency tree / graph
 
Reported: 2011-09-22 13:11 PDT by Mark Hahnenberg
Modified: 2011-09-23 18:19 PDT (History)
0 users

See Also:

Attachments
Patch (8.04 KB, patch)
2011-09-22 14:55 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (8.96 KB, patch)
2011-09-22 16:45 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (8.98 KB, patch)
2011-09-22 16:46 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (9.23 KB, patch)
2011-09-22 17:34 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Retrying windows (9.37 KB, patch)
2011-09-23 13:05 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Retrying windows (9.28 KB, patch)
2011-09-23 13:11 PDT, Mark Hahnenberg 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-09-22 13:11:02 PDT 
In the ongoing process of de-virtualizing JSCell, we now come to JSCell::getJSNumber.
Comment 1 Mark Hahnenberg 2011-09-22 14:55:40 PDT 
Created attachment 108405 [details]
Patch
Comment 2 Geoffrey Garen 2011-09-22 16:00:35 PDT 
Comment on attachment 108405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108405&action=review

Please make NumberObject-ness a type instead of a flag.

> Source/JavaScriptCore/runtime/JSTypeInfo.h:46
> +    static const unsigned IsNumberObject = 1 << 9;

I think this would be better as a JSType rather than a Structure flag. Flags are states that many kinds of objects might have; types identify a specific kind of object. Nothing other than NumberObject wants to set the IsNumberObject flag.
Comment 3 Mark Hahnenberg 2011-09-22 16:45:02 PDT 
Created attachment 108418 [details]
Patch
Comment 4 Mark Hahnenberg 2011-09-22 16:46:53 PDT 
Created attachment 108419 [details]
Patch
Comment 5 Mark Hahnenberg 2011-09-22 17:34:37 PDT 
Created attachment 108430 [details]
Patch
Comment 6 Geoffrey Garen 2011-09-22 17:39:11 PDT 
Comment on attachment 108430 [details]
Patch

r=me
Comment 7 Mark Hahnenberg 2011-09-23 13:05:40 PDT 
Created attachment 108514 [details]
Retrying windows
Comment 8 Mark Hahnenberg 2011-09-23 13:11:27 PDT 
Created attachment 108516 [details]
Retrying windows
Comment 9 Oliver Hunt 2011-09-23 18:05:36 PDT 
Comment on attachment 108516 [details]
Retrying windows

r=me
Comment 10 Mark Hahnenberg 2011-09-23 18:19:02 PDT 
Committed r95893: <http://trac.webkit.org/changeset/95893>