RESOLVED FIXED 68651
De-virtualize JSCell::getJSNumber 
https://bugs.webkit.org/show_bug.cgi?id=68651
Summary De-virtualize JSCell::getJSNumber
Mark Hahnenberg
Reported 2011-09-22 13:11:02 PDT
In the ongoing process of de-virtualizing JSCell, we now come to JSCell::getJSNumber.
Attachments
Patch (8.04 KB, patch)
2011-09-22 14:55 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (8.96 KB, patch)
2011-09-22 16:45 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (8.98 KB, patch)
2011-09-22 16:46 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (9.23 KB, patch)
2011-09-22 17:34 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Retrying windows (9.37 KB, patch)
2011-09-23 13:05 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Retrying windows (9.28 KB, patch)
2011-09-23 13:11 PDT, Mark Hahnenberg 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-09-22 14:55:40 PDT
Created attachment 108405 [details] Patch
Geoffrey Garen
Comment 2 2011-09-22 16:00:35 PDT
Comment on attachment 108405 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108405&action=review Please make NumberObject-ness a type instead of a flag. > Source/JavaScriptCore/runtime/JSTypeInfo.h:46 > + static const unsigned IsNumberObject = 1 << 9; I think this would be better as a JSType rather than a Structure flag. Flags are states that many kinds of objects might have; types identify a specific kind of object. Nothing other than NumberObject wants to set the IsNumberObject flag.
Mark Hahnenberg
Comment 3 2011-09-22 16:45:02 PDT
Created attachment 108418 [details] Patch
Mark Hahnenberg
Comment 4 2011-09-22 16:46:53 PDT
Created attachment 108419 [details] Patch
Mark Hahnenberg
Comment 5 2011-09-22 17:34:37 PDT
Created attachment 108430 [details] Patch
Geoffrey Garen
Comment 6 2011-09-22 17:39:11 PDT
Comment on attachment 108430 [details] Patch r=me
Mark Hahnenberg
Comment 7 2011-09-23 13:05:40 PDT
Created attachment 108514 [details] Retrying windows
Mark Hahnenberg
Comment 8 2011-09-23 13:11:27 PDT
Created attachment 108516 [details] Retrying windows
Oliver Hunt
Comment 9 2011-09-23 18:05:36 PDT
Comment on attachment 108516 [details] Retrying windows r=me
Mark Hahnenberg
Comment 10 2011-09-23 18:19:02 PDT
Committed r95893: <http://trac.webkit.org/changeset/95893>
Note You need to log in before you can comment on or make changes to this bug.