Bug 68634 - [GTK] Fix coding style bits in ResourceHandleSoup.cpp
Summary: [GTK] Fix coding style bits in ResourceHandleSoup.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-22 10:18 PDT by Sergio Villar Senin
Modified: 2011-09-26 02:04 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.67 KB, patch)
2011-09-22 10:23 PDT, Sergio Villar Senin
no flags Details | Formatted Diff | Diff
Patch (1.36 KB, patch)
2011-09-22 10:30 PDT, Sergio Villar Senin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2011-09-22 10:18:54 PDT
The following coding style errors should be fixed:

Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:865:  Use 0 instead of NULL.  [readability/null] [5]
Comment 1 Sergio Villar Senin 2011-09-22 10:23:50 PDT
Created attachment 108355 [details]
Patch
Comment 2 Philippe Normand 2011-09-22 10:25:51 PDT
Comment on attachment 108355 [details]
Patch

0 is not a proper sentinel
Comment 3 Sergio Villar Senin 2011-09-22 10:30:54 PDT
Created attachment 108357 [details]
Patch
Comment 4 Sergio Villar Senin 2011-09-26 00:48:55 PDT
Comment on attachment 108357 [details]
Patch

I'll let the commit-queue land this stupid bug I used to demonstrate some of the webkit-patch capabilities.
Comment 5 WebKit Review Bot 2011-09-26 02:04:07 PDT
Comment on attachment 108357 [details]
Patch

Clearing flags on attachment: 108357

Committed r95938: <http://trac.webkit.org/changeset/95938>
Comment 6 WebKit Review Bot 2011-09-26 02:04:12 PDT
All reviewed patches have been landed.  Closing bug.