WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
68628
Remove FindSafari
https://bugs.webkit.org/show_bug.cgi?id=68628
Summary
Remove FindSafari
Adam Roben (:aroben)
Reported
2011-09-22 09:28:50 PDT
After
bug 68626
is fixed, FindSafari won't be used anymore. We should remove it!
Attachments
Remove FindSafari from all our .sln files
(18.88 KB, patch)
2011-09-22 09:31 PDT
,
Adam Roben (:aroben)
sfalken
: review+
Details
Formatted Diff
Diff
Remove FindSafari
(51.63 KB, patch)
2011-09-22 09:40 PDT
,
Adam Roben (:aroben)
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1
2011-09-22 09:31:40 PDT
Created
attachment 108346
[details]
Remove FindSafari from all our .sln files
Adam Roben (:aroben)
Comment 2
2011-09-22 09:40:08 PDT
Created
attachment 108349
[details]
Remove FindSafari
Darin Adler
Comment 3
2011-09-22 10:00:27 PDT
Comment on
attachment 108349
[details]
Remove FindSafari Not sure why patch doesn’t apply. Change log for this should be shorter without so much detail. I see no need to list the individual files in the change log.
Adam Roben (:aroben)
Comment 4
2011-09-22 10:28:14 PDT
(In reply to
comment #3
)
> (From update of
attachment 108349
[details]
) > Not sure why patch doesn’t apply.
I'm not sure why either.
> Change log for this should be shorter without so much detail. I see no need to list the individual files in the change log.
OK, I'll shorten it. Thanks for reviewing!
Adam Roben (:aroben)
Comment 5
2011-09-22 10:52:21 PDT
Committed
r95735
: <
http://trac.webkit.org/changeset/95735
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug