Bug 68628 - Remove FindSafari
Summary: Remove FindSafari
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: PlatformOnly
Depends on: 68626
Blocks:
  Show dependency tree / graph
 
Reported: 2011-09-22 09:28 PDT by Adam Roben (:aroben)
Modified: 2011-09-22 10:52 PDT (History)
1 user (show)

See Also:

Attachments
Remove FindSafari from all our .sln files (18.88 KB, patch)
2011-09-22 09:31 PDT, Adam Roben (:aroben) 		sfalken: review+
Details | Formatted Diff | Diff
Remove FindSafari (51.63 KB, patch)
2011-09-22 09:40 PDT, Adam Roben (:aroben) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-09-22 09:28:50 PDT 
After bug 68626 is fixed, FindSafari won't be used anymore. We should remove it!
Comment 1 Adam Roben (:aroben) 2011-09-22 09:31:40 PDT 
Created attachment 108346 [details]
Remove FindSafari from all our .sln files
Comment 2 Adam Roben (:aroben) 2011-09-22 09:40:08 PDT 
Created attachment 108349 [details]
Remove FindSafari
Comment 3 Darin Adler 2011-09-22 10:00:27 PDT 
Comment on attachment 108349 [details]
Remove FindSafari

Not sure why patch doesn’t apply. Change log for this should be shorter without so much detail. I see no need to list the individual files in the change log.
Comment 4 Adam Roben (:aroben) 2011-09-22 10:28:14 PDT 
(In reply to comment #3)
> (From update of attachment 108349 [details])
> Not sure why patch doesn’t apply.

I'm not sure why either.

> Change log for this should be shorter without so much detail. I see no need to list the individual files in the change log.

OK, I'll shorten it.

Thanks for reviewing!
Comment 5 Adam Roben (:aroben) 2011-09-22 10:52:21 PDT 
Committed r95735: <http://trac.webkit.org/changeset/95735>