68621 – build-webkit goes totally haywire on Windows if there are spaces in the path to the WebKit source tree

RESOLVED FIXED 68621

build-webkit goes totally haywire on Windows if there are spaces in the path to the WebKit source tree

https://bugs.webkit.org/show_bug.cgi?id=68621

Summary build-webkit goes totally haywire on Windows if there are spaces in the path ...

Adam Roben (:aroben)

Reported 2011-09-22 08:20:47 PDT

To reproduce: 1. Check out WebKit to some location that has spaces in its path 2. build-webkit You'll get all sorts of funky errors from Visual Studio.

Attachments
Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath (1.40 KB, patch) 2011-09-22 08:23 PDT, Adam Roben (:aroben)	sullivan: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2011-09-22 08:23:24 PDT

Created attachment 108337 [details] Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath

Adam Roben (:aroben)

Comment 2 2011-09-22 10:51:26 PDT

Committed r95731: <http://trac.webkit.org/changeset/95731>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware PC

OS Windows 7

Product WebKit

Component Tools / Tests

Assignee

Adam Roben (:aroben)

Reported

2011-09-22 08:20 PDT

Modified

2011-09-22 10:51 PDT History

CC List

1 user Show

URL

Keywords PlatformOnly

Depends on

Blocks