Bug 68615 - [Gtk] Title attribute is not respected on option elements
Summary: [Gtk] Title attribute is not respected on option elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 27864
  Show dependency treegraph
 
Reported: 2011-09-22 06:19 PDT by Deepak Sherveghar
Modified: 2011-09-23 07:13 PDT (History)
2 users (show)

See Also:


Attachments
HTML testcase attached. (416 bytes, text/html)
2011-09-22 06:20 PDT, Deepak Sherveghar
no flags Details
Patch. (2.39 KB, patch)
2011-09-22 06:29 PDT, Deepak Sherveghar
mrobinson: review-
Details | Formatted Diff | Diff
Updated Patch (2.58 KB, patch)
2011-09-22 22:59 PDT, Deepak Sherveghar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Deepak Sherveghar 2011-09-22 06:19:33 PDT
If I create an <option> element with title="option's title text" in a <select>, the tooltip will not be shown in GTK.
Comment 1 Deepak Sherveghar 2011-09-22 06:20:50 PDT
Created attachment 108324 [details]
HTML testcase attached.
Comment 2 Deepak Sherveghar 2011-09-22 06:29:15 PDT
Created attachment 108326 [details]
Patch.
Comment 3 Martin Robinson 2011-09-22 09:19:59 PDT
Comment on attachment 108326 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=108326&action=review

Looks good to me, but I have a few ChangeLog nits below.

> Source/WebCore/ChangeLog:3
> +        [Gtk] Respect Title attribute on Option elements.

This line should be the bug title: [Gtk] Title attribute is not respected on option elements

> Source/WebCore/ChangeLog:8
> +        Set Tooltip on menuitem widget created from GTKAction.

Watch you capilization here. Probably better to say something like: Set tooltip on PopupMenuGtk items created from GtkActions.

> Source/WebCore/ChangeLog:13
> +        * platform/gtk/GtkPopupMenu.cpp:
> +        (WebCore::GtkPopupMenu::appendItem):
> +        * platform/gtk/PopupMenuGtk.cpp:
> +        (WebCore::PopupMenuGtk::createGtkActionForMenuItem):

Please fill these out.
Comment 4 Deepak Sherveghar 2011-09-22 22:59:44 PDT
Created attachment 108443 [details]
Updated Patch
Comment 5 WebKit Review Bot 2011-09-23 07:13:07 PDT
Comment on attachment 108443 [details]
Updated Patch

Clearing flags on attachment: 108443

Committed r95800: <http://trac.webkit.org/changeset/95800>
Comment 6 WebKit Review Bot 2011-09-23 07:13:11 PDT
All reviewed patches have been landed.  Closing bug.