Bug 68613 – Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved. Send attribute name and value within the event.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

This change also splits attributeModified and attributeRemoved notifications.

[Pavel Feldman]

Created attachment 108677 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 108677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108677&action=review

> Source/WebCore/inspector/Inspector.draft-01.json:1182
> +                    { "name": "name", "type": "string", "description": "Local attirbute name." },

typo: attirbute -> attribute, I'd also change it to Attribute's local name.

> Source/WebCore/inspector/Inspector.draft-01.json:1183
> +                    { "name": "value", "type": "string", "description": "Attirbute name." }

Attirbute name. -> New attribute value.

> Source/WebCore/inspector/Inspector.json:1183
> +                    { "name": "value", "type": "string", "description": "Attirbute name." }

Same typos here.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1681
> +        this._parentPane._userOperation = true;

This lines don't seem to be a part of this change, remove them.

[Pavel Feldman]

Created attachment 108842 [details]
[Patch] separated attrRemoved event on the front-end as well.

[Yury Semikhatsky]

Comment on attachment 108842 [details]
[Patch] separated attrRemoved event on the front-end as well.

View in context: https://bugs.webkit.org/attachment.cgi?id=108842&action=review

> LayoutTests/inspector/elements/mutate-unknown-node.html-disabled:31
> +        node = event.data.node || event.data;

Please use two separate listeners instead.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:287
> +        // Chanding style attribute will anyways generate _styleInvalidated message. 

Changing

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:291
> +        // "classname" attribute might have changed. Update styles unless they are being edited.

classname -> class

[Pavel Feldman]

Committed r96106: <http://trac.webkit.org/changeset/96106>