Bug 6860 - REGRESSION: crash when setting a list with list-style: none to display: none
Summary: REGRESSION: crash when setting a list with list-style: none to display: none
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Major
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-26 19:29 PST by Maciej Stachowiak
Modified: 2006-01-31 21:20 PST (History)
0 users

See Also:

Attachments
A test case demonstrating the crash (451 bytes, text/html)
2006-01-26 19:31 PST, Maciej Stachowiak 		no flags Details
the fix (including test case) (4.22 KB, patch)
2006-01-26 19:40 PST, Maciej Stachowiak 		timo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2006-01-26 19:29:08 PST 
When you change a list that has list-style: none to also be display: none, there is a crash due to a missing nil check.
Comment 1 Maciej Stachowiak 2006-01-26 19:31:31 PST 
Created attachment 6004 [details]
A test case demonstrating the crash
Comment 2 Maciej Stachowiak 2006-01-26 19:31:54 PST 
This is a regression, it does not happen in Safari 2.0.2.
Comment 3 Maciej Stachowiak 2006-01-26 19:40:48 PST 
Created attachment 6005 [details]
the fix (including test case)
Comment 4 Maciej Stachowiak 2006-01-26 19:45:02 PST 
A reproducible crasher regression should be P1.
Comment 5 Tim Omernick 2006-01-26 20:44:10 PST 
Comment on attachment 6005 [details]
the fix (including test case)

r=me
Comment 6 Maciej Stachowiak 2006-01-26 21:15:56 PST 
Looks like Dave Harrison fixed this (in the exact same way, line for line) but I'll add the layout test anyway.
Comment 7 Eric Seidel (no email) 2006-01-31 21:20:48 PST 
Removing Regression keyword from bugs already fixed.