Bug 68594 - [EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_internal.
Summary: [EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_int...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-21 23:26 PDT by KwangHyuk
Modified: 2011-09-28 19:51 PDT (History)
7 users (show)

See Also:

Attachments
Patch. (2.07 KB, patch)
2011-09-21 23:28 PDT, KwangHyuk 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description KwangHyuk 2011-09-21 23:26:57 PDT 
As the 1st assignment of local variable bx in _ewk_tiled_backing_store_zoom_set_internal isn't effective at all, this patch just removes it.
Comment 1 KwangHyuk 2011-09-21 23:28:58 PDT 
Created attachment 108280 [details]
Patch.
Comment 2 Lucas De Marchi 2011-09-22 06:09:53 PDT 
Comment on attachment 108280 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=108280&action=review

> Source/WebKit/efl/ChangeLog:7
> +        [EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_internal.
> +        https://bugs.webkit.org/show_bug.cgi?id=68594
> +
> +        As the 1st assignment of local variable bx in _ewk_tiled_backing_store_zoom_set_internal
> +        isn't effective at all, this patch just removes it.

Are you using any static analyzer tool? Could you mention it here?

I think patches like this would be better to be applied all together instead of going through each function and opening a separate bug.
Comment 3 KwangHyuk 2011-09-22 06:19:34 PDT 
> Are you using any static analyzer tool? Could you mention it here?
>
> I think patches like this would be better to be applied all together instead of going through each function and opening a separate bug.

No, Unfortunately, static analyzer didn't detect it ever before.
I noticed this while I was checking the way to reduce number of calling smart calculate on ewk's tiled backing store.
Comment 4 Raphael Kubo da Costa (:rakuco) 2011-09-22 09:47:36 PDT 
LGTM.
Comment 5 Gyuyoung Kim 2011-09-27 19:13:14 PDT 
Comment on attachment 108280 [details]
Patch.

LGTM. 1503 line is unneeded code.
Comment 6 WebKit Review Bot 2011-09-28 19:51:17 PDT 
Comment on attachment 108280 [details]
Patch.

Clearing flags on attachment: 108280

Committed r96291: <http://trac.webkit.org/changeset/96291>
Comment 7 WebKit Review Bot 2011-09-28 19:51:22 PDT 
All reviewed patches have been landed.  Closing bug.