Bug 68594 – [EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_internal.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[KwangHyuk]

As the 1st assignment of local variable bx in _ewk_tiled_backing_store_zoom_set_internal isn't effective at all, this patch just removes it.

[KwangHyuk]

Created attachment 108280 [details]
Patch.

[Lucas De Marchi]

Comment on attachment 108280 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=108280&action=review

> Source/WebKit/efl/ChangeLog:7
> +        [EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_internal.
> +        https://bugs.webkit.org/show_bug.cgi?id=68594
> +
> +        As the 1st assignment of local variable bx in _ewk_tiled_backing_store_zoom_set_internal
> +        isn't effective at all, this patch just removes it.

Are you using any static analyzer tool? Could you mention it here?

I think patches like this would be better to be applied all together instead of going through each function and opening a separate bug.

[KwangHyuk]

> Are you using any static analyzer tool? Could you mention it here?
>
> I think patches like this would be better to be applied all together instead of going through each function and opening a separate bug.

No, Unfortunately, static analyzer didn't detect it ever before.
I noticed this while I was checking the way to reduce number of calling smart calculate on ewk's tiled backing store.

[Raphael Kubo da Costa (:rakuco)]

LGTM.

[Gyuyoung Kim]

Comment on attachment 108280 [details]
Patch.

LGTM. 1503 line is unneeded code.

[WebKit Review Bot]

Comment on attachment 108280 [details]
Patch.

Clearing flags on attachment: 108280

Committed r96291: <http://trac.webkit.org/changeset/96291>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.