Bug 68587 - Enable WEB_AUDIO by default in the WebKit/mac port.
Summary: Enable WEB_AUDIO by default in the WebKit/mac port.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on: 69292
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-21 17:15 PDT by Jer Noble
Modified: 2011-10-21 21:11 PDT (History)
5 users (show)

See Also:


Attachments
Patch (159.37 KB, patch)
2011-09-22 11:01 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (168.55 KB, patch)
2011-10-05 14:54 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-09-21 17:15:05 PDT
Enable WEB_AUDIO by default in the WebKit/mac port.
Comment 1 Jer Noble 2011-09-22 11:01:45 PDT
Created attachment 108365 [details]
Patch
Comment 2 Simon Fraser (smfr) 2011-09-22 15:32:54 PDT
Comment on attachment 108365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108365&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:7006
> +				CD0DBFF01422768500280263 /* IRC_Composite_C_R0195_T345_P345.wav in Copy Audio Resources */,

What does this to do the framework size?
Comment 3 Jer Noble 2011-09-22 15:37:11 PDT
(In reply to comment #2)
> (From update of attachment 108365 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108365&action=review
> 
> > Source/WebCore/WebCore.xcodeproj/project.pbxproj:7006
> > +				CD0DBFF01422768500280263 /* IRC_Composite_C_R0195_T345_P345.wav in Copy Audio Resources */,
> 
> What does this to do the framework size?

It adds about 980 KB of resources.
Comment 4 Chris Rogers 2011-09-23 11:33:16 PDT
The total data size of the files is around 250K - the folder may show a larger size due to the number of files and disk sector allocation
Comment 5 WebKit Review Bot 2011-10-03 12:20:10 PDT
Comment on attachment 108365 [details]
Patch

Clearing flags on attachment: 108365

Committed r96526: <http://trac.webkit.org/changeset/96526>
Comment 6 WebKit Review Bot 2011-10-03 12:20:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Jer Noble 2011-10-03 14:57:23 PDT
Reverted r96526 for reason:

WEB_AUDIO has numerous 64->32 bit casting warnings, causing build breakages where -Wall is enabled.

Committed r96545: <http://trac.webkit.org/changeset/96545>
Comment 8 Jer Noble 2011-10-05 14:54:42 PDT
Created attachment 109868 [details]
Patch

Now that bug #69292 is fixed, resubmitting this patch for approval, but now with LayoutTest changes to support the additional Window properties added by this patch.
Comment 9 WebKit Review Bot 2011-10-05 17:39:48 PDT
Comment on attachment 109868 [details]
Patch

Clearing flags on attachment: 109868

Committed r96774: <http://trac.webkit.org/changeset/96774>
Comment 10 WebKit Review Bot 2011-10-05 17:39:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Ryosuke Niwa 2011-10-07 12:47:44 PDT
It seems like fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, and fast/js/global-constructors.html started failing after this patch was landed:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r96941%20(33722)/results.html
Comment 12 Jer Noble 2011-10-10 16:38:29 PDT
(In reply to comment #11)
> It seems like fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, and fast/js/global-constructors.html started failing after this patch was landed:
> http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r96941%20(33722)/results.html

Filed https://bugs.webkit.org/show_bug.cgi?id=69800.
Comment 13 Grant Galitz 2011-10-21 21:11:53 PDT
Web audio still has issues with its onprocessaudio event for the JavaScriptNode firing late / not enough on Mac OS X (Gaps in the audio happen sometimes, and fails miserably with timing during high CPU taxing, unlike how flash performs). However, the web audio for windows (tested in chrome on windows 7) is completely trashed, and fails to fire its events enough under light CPU load.

Reference URL: http://grantgalitz.org/gamecenter/#PokemonYellow (Sigh, I know this is getting old, but my JavaScript GameBoy Color does use Web Audio + Flash Audio + Mozilla Audio). To force web audio on windows / linux, disable flash, since I blacklist web audio upon detection of these host OSes due to the critical web audio bugs (So I attempt flash over web audio for win/linux.).