Bug 68586 - Add X86 GPRInfo for DFG JIT.
Summary: Add X86 GPRInfo for DFG JIT.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 67460
  Show dependency treegraph
 
Reported: 2011-09-21 16:34 PDT by Gavin Barraclough
Modified: 2011-09-21 16:49 PDT (History)
0 users

See Also:


Attachments
Fix (3.24 KB, patch)
2011-09-21 16:35 PDT, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-09-21 16:34:15 PDT
X86 has fewer registers!
Comment 1 Gavin Barraclough 2011-09-21 16:35:09 PDT
Created attachment 108252 [details]
Fix
Comment 2 Geoffrey Garen 2011-09-21 16:44:37 PDT
Comment on attachment 108252 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=108252&action=review

r=me

> Source/JavaScriptCore/dfg/DFGGPRInfo.h:46
> +    // These registers match the old JIT.

Let's call this "baseline JIT".

> Source/JavaScriptCore/dfg/DFGGPRInfo.h:59
> +    static const GPRReg argumentGPR0 = X86Registers::ecx; // regT2
> +    static const GPRReg argumentGPR1 = X86Registers::edx; // regT1
> +    static const GPRReg returnValueGPR = X86Registers::eax; // regT0
> +    static const GPRReg returnValueGPR2 = X86Registers::edx; // regT1

This numbering convention is not consistent. Would be good to make it so in a future patch.
Comment 3 Gavin Barraclough 2011-09-21 16:49:30 PDT
fixed in r95684