Bug 68577 – Clipped high quality blur in skia has been fixed. Rebaseline layout tests.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

Clipped high quality blur in skia has been fixed. Rebaseline layout tests.

Created attachment 108244 [details]
Patch

A skia change ( http://code.google.com/p/skia/source/detail?r=2211 ) fixes issues with clipped blurs. This fix is currently disabled in chromium. In order to enable this fix, the chromium test fast/box-shadow/shadow-buffer-partial needs to be updated, as it currently has an incorrect blur. This change will be to update the expected png and re-enable the test.

This is the final steps of the process which began with 67724.

Created attachment 108248 [details]
Patch

Copy paste error in comment #2. The blur fix is actually enabled now in chromium.

This change is just to update and re-enable the layout tests. The patch is the result of 'webkit-patch rebaseline-expectations' with the three disabled tests 'REBASELINE', now that webkit has rolled chromium past where the blur fix was enabled in chromium.

[WebKit Review Bot]

Comment on attachment 108248 [details]
Patch

Attachment 108248 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9793038

New failing tests:
fast/box-shadow/shadow-buffer-partial.html

Created attachment 108472 [details]
Patch

[WebKit Review Bot]

Comment on attachment 108472 [details]
Patch

Attachment 108472 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9801572

New failing tests:
svg/custom/svg-fonts-word-spacing.html

Comment on attachment 108472 [details]
Patch

After waiting a short time, doing the same thing again appears to work.

The test mentioned as failing in the comment by the buildbot ( svg/custom/svg-fonts-word-spacing.html ) was not a test touched in any way by this patch.

[Kenneth Russell]

Comment on attachment 108472 [details]
Patch

The new baselines look okay to me though I wasn't able to visually see any difference between them and those in the tree right now. I'll mark this r+ and defer the setting of cq+ to someone in your local office in case there's something you want to change before landing.

[WebKit Review Bot]

Comment on attachment 108472 [details]
Patch

Clearing flags on attachment: 108472

Committed r96107: <http://trac.webkit.org/changeset/96107>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.